Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for keyed services in beans/services actuator #1378

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Oct 7, 2024

Description

Adds support for keyed services in the /actuator/beans management endpoint. This PR adds a key property that is non-null for a keyed service. For test coverage, I've added keyed variants of the existing tests.

I've considered mapping to Spring aliases instead of introducing key, but I believe that's not entirely the same concept.

image

Fixes #1377.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware
Copy link
Member Author

/azp run Steeltoe.All

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

sonarqubecloud bot commented Oct 7, 2024

@bart-vmware bart-vmware marked this pull request as ready for review October 7, 2024 10:07
@bart-vmware bart-vmware requested a review from TimHess October 7, 2024 10:07
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM (thanks for the quick fix), and I agree on the alias analysis

@TimHess TimHess changed the title Add support for keyed services in actuator Add support for keyed services in beans/services actuator Oct 7, 2024
@TimHess TimHess added Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Oct 7, 2024
@TimHess TimHess added this to the 4.0.0-m1 milestone Oct 7, 2024
@bart-vmware bart-vmware merged commit f74a05b into main Oct 7, 2024
15 checks passed
@bart-vmware bart-vmware deleted the fix-keyed-services branch October 7, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beans/Services actuator crash: Your service provider may not support keyed services.
2 participants