Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul: don't log exception on termination #1372

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Consul: don't log exception on termination #1372

merged 1 commit into from
Oct 2, 2024

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Oct 2, 2024

Description

The exception contains no useful information. Logging it suggests something crashed, while this is expected behavior. I found this while running the FortuneTeller sample in a console application.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware
Copy link
Member Author

/azp run Steeltoe.All

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

sonarqubecloud bot commented Oct 2, 2024

@bart-vmware bart-vmware marked this pull request as ready for review October 2, 2024 09:06
@bart-vmware bart-vmware requested a review from TimHess October 2, 2024 09:06
@bart-vmware bart-vmware merged commit 150b58b into main Oct 2, 2024
15 checks passed
@bart-vmware bart-vmware deleted the fix-consul branch October 2, 2024 13:41
@bart-vmware bart-vmware added Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants