Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pausing of initial messages #2478

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Allow pausing of initial messages #2478

merged 2 commits into from
Oct 18, 2024

Conversation

jeffm2001
Copy link
Collaborator

Description

We've had instances where we needed to pause all our campaigns but still wanted texters to be able to respond to replies for messages that have already gone out. This makes it possible to do that by setting a DOWNTIME_NO_INITIAL environment variable. When the environment variable is set, instead of seeing the normal texting interface texters will see a message saying "Sending initial messages is currently paused. You can still reply to any incoming messages."

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@engelhartrueben
Copy link
Collaborator

I really like the idea, but am hesitant with with instances that have many organizations running/texting concurrently. Also, having to restart the application and set DOWNTIME_NO_INITIAL may be too disruptive (again, when there are many orgs).

Has this been mostly used when there has been something wrong with the application? Or to stop texting in general?

@jeffm2001
Copy link
Collaborator Author

The goal was to have something slightly less disruptive than setting DOWNTIME or DOWNTIME_TEXTER. I think we used it twice, once when we were switching from Twilio to Bandwidth and needed to wind down active campaigns, and once when we were dealing with scaling/instability issues and wanted to scale back activity without shutting down entirely.

Agree that it would be nice if it could be done on a per-organization or even per-campaign basis, but the implementation of that would get trickier.

@engelhartrueben engelhartrueben changed the base branch from main to stage-main-14.2 October 15, 2024 13:52
@engelhartrueben engelhartrueben added the S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage label Oct 15, 2024
@engelhartrueben engelhartrueben self-requested a review October 18, 2024 18:54
engelhartrueben
engelhartrueben approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@engelhartrueben engelhartrueben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mau11 mau11 changed the base branch from stage-main-14.2 to stage-main-14.1.2 October 18, 2024 18:54
@mau11 mau11 merged commit a1d6ce5 into StateVoicesNational:stage-main-14.1.2 Oct 18, 2024
8 checks passed
@engelhartrueben engelhartrueben mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelhartrueben engelhartrueben engelhartrueben approved these changes

Assignees
No one assigned
Labels
S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffm2001 @engelhartrueben @mau11