Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2409 / Reset Password Bug #2424

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Fix #2409 / Reset Password Bug #2424

merged 2 commits into from
Aug 19, 2024

Conversation

engelhartrueben
Copy link
Collaborator

Fixes # (issue)

Fix #2409

Description

userId was passed as string, needed to be an integer

Draft PR because I want to find why the tests still passed.

NOTE set up for stage-main-14.1, can rebase for path upon request.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@engelhartrueben engelhartrueben requested a review from mau11 August 15, 2024 21:26
mau11
mau11 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@mau11 mau11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can change the base to a 14.0.2 branch

@mau11 mau11 changed the base branch from stage-main-14.1 to stage-main-14.0.2 August 18, 2024 14:34
@mau11
Copy link
Member

mau11 commented Aug 19, 2024

@engelhartrueben I updated the base to the new 14.0.2 branch, you can rebase the 14.1 updates out by rebasing with this command: $ git rebase --onto main stage-main-14.1 re/fix-reset-password, then force push the change to this branch

@engelhartrueben
Copy link
Collaborator Author

The reason why these tests passed with this bug is because the button to reset passwords was broken, and not the functionality behind it. Unsure if jest could have caught this, but definitely cypress.

@engelhartrueben engelhartrueben marked this pull request as ready for review August 19, 2024 13:29
@engelhartrueben engelhartrueben merged commit 50caf96 into stage-main-14.0.2 Aug 19, 2024
17 checks passed
@engelhartrueben engelhartrueben deleted the re/fix-reset-password branch August 19, 2024 14:46
@mau11 mau11 mentioned this pull request Aug 19, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mau11 mau11 mau11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engelhartrueben @mau11