Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/2382: currentInteractionStep variable needs to continue w/in block instead of new const #2383

Conversation

schuyler1d
Copy link
Collaborator

Fixes #2382

Description

fixes #2382

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@@ -125,10 +125,9 @@ export class AssignmentTexterContactControls extends React.Component {
let currentInteractionStep = null;

if (availableSteps.length > 0) {
const currentInteractionStep = deepCopy(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️ thanks for catching this

Copy link
Member

@mau11 mau11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@engelhartrueben engelhartrueben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

@engelhartrueben engelhartrueben changed the base branch from main to stage-patch-main-14.0.1 July 23, 2024 21:40
@engelhartrueben engelhartrueben merged commit 54660f4 into StateVoicesNational:stage-patch-main-14.0.1 Jul 23, 2024
8 checks passed
@engelhartrueben engelhartrueben mentioned this pull request Jul 24, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: All responses on reply screen breaks
4 participants