-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated changelog #101
Updated changelog #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Comments are just nitpicking.
Changelog.md
Outdated
- The `Stampie\MailerInterface::send` method no longer return a boolean. Errors are now reported using exceptions that implements `Stampie\ExceptionInterface`. As core mailers were already throwing exceptions when sending a message, the BC break impact is limited. | ||
- The `SendGrid` mailer is updated to version 3. Please update your token. | ||
- We use PSR4 instead of PSR0 for auto loading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PSRs used to be written PSR-X
.
Changelog.md
Outdated
|
||
### Added | ||
|
||
- All exception implements `Stampie\ExceptionInterface` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you end this sentence with a .
?
Changelog.md
Outdated
### Removed | ||
|
||
- The `setHttpClient`, `setServerToken` and `getServerToken` methods have been removed from `Stampie\MailerInterface`. | ||
- `Response` and `ResponseInterface` has been removed in favor of PSR7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing final .
.
Thank you! |
Prepare for release beta 1.