Fix issue where exe files were not removed during uninstall. #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
|
@anaisbetts any chance of getting this reviewed? We currently use a forked version of this but it would be nice to have it in the main package. |
anaisbetts
reviewed
Oct 23, 2020
| var assembly = AssemblyDefinition.ReadAssembly(executable); | ||
| if (!assembly.HasCustomAttributes) return null; | ||
| using (var assembly = AssemblyDefinition.ReadAssembly(executable)) | ||
| { |
There was a problem hiding this comment.
⬆️, the bracket belongs on the same line
There was a problem hiding this comment.
Updated to what I think you meant.
johan-lindqvist
force-pushed
the
branches/exe-files-not-removed-during-uninstall
branch
from
bdbb879 to
db240d8
Compare
This error occured due to a disposable resource not being disposed.
johan-lindqvist
force-pushed
the
branches/exe-files-not-removed-during-uninstall
branch
from
db240d8 to
c982449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error occurred due to a disposable resource not being disposed.
Tested with our application and the change resolves the issue of exe-files not being removed since version 2.0.0.
Fixes #1641
Sidenote: there's still two files left after an uninstall, a ".dead"-file, and Update.exe as described in #1586, but if I understand correctly that is expected behavior?