Changed type of property ToastActivatorCLSID in shortcut to VT_CLSID #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaisbetts
reviewed
Sep 12, 2018
src/Squirrel/ShellFile.cs
Outdated
| { | ||
| byte[] bytes = ((Guid)guid).ToByteArray(); | ||
| var pv = new PropVariant() | ||
| { |
There was a problem hiding this comment.
Can you follow the code style please.
anaisbetts
reviewed
Sep 12, 2018
src/Squirrel/ShellFile.cs
Outdated
|
|
||
| PropVariant varGuid = PropVariant.FromGuid(clsid); | ||
| try | ||
| { |
anaisbetts
reviewed
Sep 12, 2018
src/Squirrel/ShellFile.cs
Outdated
| errCode = propStore.Commit(); | ||
| Marshal.ThrowExceptionForHR(errCode); | ||
| } | ||
| finally |
anaisbetts
reviewed
Sep 12, 2018
src/Squirrel/ShellFile.cs
Outdated
| @@ -885,11 +924,33 @@ public void SetAppUserModelId(string appId) | |||
| /// Sets the ToastActivatorCLSID | |||
| /// </summary> | |||
| public void SetToastActivatorCLSID(string clsid) | |||
| { | |||
| Guid guid = Guid.Parse(clsid); | |||
|
Thanks for the PR, need to fix a few things then we can merge this |
|
Fixed code style. Is there any document with code style or automatic style check? |
|
Hello Paul, were my changes OK or I can help with something? |
|
@dmitrya1979 Thanks, sorry I missed this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ToastActivatorCLSID is VT_LPWSTR. As result toast notifications in Windows do not work since they expect VT_CLSID type. This minor fix corrects the issue