Add methods to provide on spawn and on finish tasks to thread pool builder #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpriteOvO
approved these changes
Dec 15, 2023
spdlog/src/thread_pool.rs
Outdated
| /// Provide a function that will be called on each thread of the thread pool | ||
| /// immediately after it is spawned. This can, for example, be used to set | ||
| /// core affinity for each thread. | ||
| pub fn on_thread_spawn(&mut self, f: impl Fn() + Send + Sync + 'static) -> &mut Self { |
There was a problem hiding this comment.
Suggested change
| pub fn on_thread_spawn(&mut self, f: impl Fn() + Send + Sync + 'static) -> &mut Self { | |
| pub fn on_thread_spawn<F>(&mut self, f: F) -> &mut Self | |
| where | |
| F: Fn() + Send + Sync + 'static | |
| { |
spdlog/src/thread_pool.rs
Outdated
|
|
||
| /// Provide a function that will be called on each thread of the thread pool | ||
| /// just before the thread finishes. | ||
| pub fn on_thread_finish(&mut self, f: impl Fn() + Send + Sync + 'static) -> &mut Self { |
There was a problem hiding this comment.
Suggested change
| pub fn on_thread_finish(&mut self, f: impl Fn() + Send + Sync + 'static) -> &mut Self { | |
| pub fn on_thread_finish<F>(&mut self, f: F) -> &mut Self | |
| where | |
| F: Fn() + Send + Sync + 'static | |
| { |
|
Appreciate your work! ^^ PR merged and it will be included in v0.4.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from discussion in #51, this PR adds two methods to
ThreadPoolBuilder:on_thread_spawnandon_thread_finish. These allow for functions to be provided that are called immediately after each pool thread is spawned and immediately before it finishes.An example of where these may be useful is for setting core affinity for each thread in the thread pool. This use case inspired the original PR (#51); the implementation in this PR is a completely general interface that also makes this possible.