Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sleep_msec_no_row config value to balance CPU usage and TTFB #229

Merged
merged 4 commits into from
Jul 13, 2022
Merged

feat: add sleep_msec_no_row config value to balance CPU usage and TTFB #229

merged 4 commits into from
Jul 13, 2022

Conversation

laysakura
Copy link
Contributor

@laysakura laysakura commented Jul 13, 2022 •
edited
Loading

Issue number and link

Describe your changes

  • add worker.sleep_msec_no_row config value
  • change the default value from 10 to 100 to reduce CPU usage

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #229 (38ab00a) into main (86b9678) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 38ab00a differs from pull request most recent head 844f450. Consider uploading reports for the commit 844f450 to get more accurate results

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   84.06%   84.01%   -0.06%     
==========================================
  Files         219      219              
  Lines       12781    12777       -4     
==========================================
- Hits        10744    10734      -10     
- Misses       2037     2043       +6
Impacted Files Coverage Δ
springql-core/src/api/spring_config.rs 85.29% <ø> (ø)
...stream_engine/autonomous_executor/task_executor.rs 98.30% <100.00%> (ø)
...mous_executor/task_executor/generic_worker_pool.rs 96.42% <100.00%> (+0.13%) ⬆️
...omous_executor/task_executor/source_worker_pool.rs 96.42% <100.00%> (+0.13%) ⬆️
...ecutor/task_executor/task_worker_thread_handler.rs 94.84% <100.00%> (ø)
springql/tests/feat_worker_config.rs 100.00% <100.00%> (ø)
...ql_processor/sql_parser/pest_parser_impl/helper.rs 78.57% <0.00%> (-14.29%) ⬇️
...e/src/sql_processor/sql_parser/pest_parser_impl.rs 87.68% <0.00%> (-0.28%) ⬇️
...onitor_worker/performance_monitor_worker_thread.rs 69.36% <0.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b9678...844f450. Read the comment docs.

@laysakura laysakura marked this pull request as ready for review July 13, 2022 02:00
@laysakura laysakura merged commit 38cf85d into main Jul 13, 2022
@laysakura laysakura deleted the feat/config-sleep_msec_no_row branch July 13, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@laysakura