Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix fleaky example-run #207

Merged
merged 2 commits into from
Jun 23, 2022
Merged

ci: fix fleaky example-run #207

merged 2 commits into from
Jun 23, 2022

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Jun 22, 2022 •
edited
Loading

Issue number and link

Fixes: #140

Describe your changes

  • start netcat on pipeline setup completed.

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@kazuk kazuk changed the title fix fleaky example-run ci: fix fleaky example-run Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022 •
edited
Loading

Codecov Report

Merging #207 (c814d9e) into main (8cafff7) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   84.75%   84.86%   +0.10%     
==========================================
  Files         211      215       +4     
  Lines       12338    12545     +207     
==========================================
+ Hits        10457    10646     +189     
- Misses       1881     1899      +18
Impacted Files Coverage Δ
...ql_processor/sql_parser/pest_parser_impl/helper.rs 78.57% <0.00%> (-14.29%) ⬇️
springql-core/src/api/spring_config.rs 85.29% <0.00%> (-8.26%) ⬇️
...onitor_worker/performance_monitor_worker_thread.rs 65.31% <0.00%> (-4.05%) ⬇️
springql-core/src/api/error/foreign_info.rs 0.00% <0.00%> (ø)
...-core/src/stream_engine/autonomous_executor/row.rs
springql-core/src/api.rs
springql-core/src/api/spring_pipeline.rs 94.73% <0.00%> (ø)
...tream_engine/autonomous_executor/row/stream_row.rs 96.07% <0.00%> (ø)
.../task/source_task/source_reader/in_memory_queue.rs 93.75% <0.00%> (ø)
springql/tests/e2e_connect_2_pipelines.rs 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cafff7...c814d9e. Read the comment docs.

@kazuk kazuk force-pushed the fix_flaky_example branch from 255f61f to ef151af Compare June 22, 2022 22:58
@kazuk kazuk requested a review from laysakura June 23, 2022 21:33
laysakura
laysakura approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 🙌 🙌

@laysakura laysakura merged commit a9e22fd into main Jun 23, 2022
@laysakura laysakura deleted the fix_flaky_example branch June 23, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laysakura laysakura laysakura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: ci / example-run test is flaky
2 participants
@kazuk @laysakura