Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add wrapping springql crate #193

Merged
merged 30 commits into from
Jun 21, 2022
Merged

feat: Add wrapping springql crate #193

merged 30 commits into from
Jun 21, 2022
+267 −204

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Jun 13, 2022 •
edited
Loading

Issue number and link

Fixes: #192

Describe your changes

  • add wrapping crate springql
  • re-export springql-core API's from springql

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@kazuk kazuk mentioned this pull request Jun 13, 2022
Merged
@codecov
Copy link

codecov bot commented Jun 13, 2022 •
edited
Loading

Codecov Report

Merging #193 (87f0518) into main (80b79c4) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   84.68%   84.72%   +0.03%     
==========================================
  Files         210      211       +1     
  Lines       12337    12338       +1     
==========================================
+ Hits        10448    10453       +5     
+ Misses       1889     1885       -4
Impacted Files Coverage Δ
springql/tests/e2e_high_level_rs.rs 100.00% <ø> (ø)
springql/tests/e2e_sampling.rs 100.00% <ø> (ø)
springql/tests/feat_aggregation.rs 100.00% <ø> (ø)
springql/tests/feat_error.rs 100.00% <ø> (ø)
springql/tests/feat_join.rs 100.00% <ø> (ø)
springql/tests/feat_logical_ops.rs 100.00% <ø> (ø)
springql/tests/feat_numerical_ops.rs 100.00% <ø> (ø)
springql/tests/feat_performance_metrics_report.rs 100.00% <ø> (ø)
springql/tests/feat_pipeline.rs 100.00% <ø> (ø)
springql/tests/feat_processing_time.rs 100.00% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b79c4...87f0518. Read the comment docs.

@kazuk kazuk marked this pull request as ready for review June 13, 2022 22:00
@kazuk kazuk requested a review from laysakura June 13, 2022 22:00
@kazuk kazuk force-pushed the add_wrapping_crate branch from ca05b4e to 242e400 Compare June 13, 2022 22:05
@laysakura laysakura changed the title Add_wrapping_crate feat: Add wrapping springql crate Jun 15, 2022
@laysakura
Copy link
Contributor

[nits]

[x] I follow the Semantic Pull Requests rules (bugfix/feature)

I changed the pull-request title to follow it.

laysakura
laysakura requested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Want to move tests/ and examples/ from springql-core into springql, in order to keep E2E tests
  • Want to eliminate duplication in springql-core and springql as much as possible.
    • springql/src/lib.md is duplicate of that of springql-core, for example.

@kazuk kazuk force-pushed the add_wrapping_crate branch from 9f5526d to 0852e47 Compare June 15, 2022 22:50
@kazuk kazuk force-pushed the add_wrapping_crate branch from 0852e47 to 19ed89a Compare June 15, 2022 23:00
@kazuk kazuk requested a review from laysakura June 15, 2022 23:24
@kazuk
Copy link
Contributor Author

kazuk commented Jun 15, 2022

CI deadlink fail with #196

laysakura
laysakura requested changes Jun 16, 2022
View reviewed changes
springql/src/lib.md Show resolved Hide resolved
springql/src/lib.rs Outdated Show resolved Hide resolved
@kazuk kazuk requested a review from laysakura June 20, 2022 23:52
laysakura
laysakura approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 🙏 💥

laysakura
laysakura requested changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. Please fix CI errors.

@laysakura
Copy link
Contributor

📝 example-run is failing due to this issue: #204

@laysakura laysakura merged commit bce3ed5 into main Jun 21, 2022
@laysakura laysakura deleted the add_wrapping_crate branch June 21, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laysakura laysakura laysakura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add wrapping crate springql
2 participants
@kazuk @laysakura