Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap chrono types #172

Merged
merged 3 commits into from
Jun 5, 2022
Merged

Wrap chrono types #172

merged 3 commits into from
Jun 5, 2022
+196 −51

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Jun 4, 2022 •
edited
Loading

Issue number and link

Fixes: #171

Describe your changes

  • introduce new-type wrapper for chrono types

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@kazuk kazuk requested a review from laysakura June 4, 2022 03:29
@codecov
Copy link

codecov bot commented Jun 4, 2022 •
edited
Loading

Codecov Report

Merging #172 (c5c1dbe) into main (e15a4b8) will increase coverage by 0.13%.
The diff coverage is 94.54%.

❗ Current head c5c1dbe differs from pull request most recent head 3b8a185. Consider uploading reports for the commit 3b8a185 to get more accurate results

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   87.83%   87.97%   +0.13%     
==========================================
  Files         203      204       +1     
  Lines       12620    12696      +76     
==========================================
+ Hits        11085    11169      +84     
+ Misses       1535     1527       -8
Impacted Files Coverage Δ
springql-core/src/lib.rs 100.00% <ø> (ø)
...ne/autonomous_executor/row/foreign_row/sink_row.rs 88.88% <ø> (ø)
springql-core/src/stream_engine/time/duration.rs 76.66% <80.00%> (ø)
springql-core/src/time.rs 94.11% <94.11%> (ø)
springql-core/src/expression.rs 74.25% <100.00%> (-2.40%) ⬇️
...am_engine/autonomous_executor/task/window/panes.rs 98.05% <100.00%> (ø)
...ngine/autonomous_executor/task/window/watermark.rs 94.44% <100.00%> (+2.13%) ⬆️
springql-core/src/stream_engine/time/timestamp.rs 99.25% <100.00%> (-0.04%) ⬇️
...c/stream_engine/time/timestamp/system_timestamp.rs 80.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15a4b8...3b8a185. Read the comment docs.

@kazuk kazuk changed the title Switch_chrono_to_time Wrap chrono types Jun 4, 2022
@kazuk kazuk mentioned this pull request Jun 4, 2022
Closed
5 tasks
laysakura
laysakura approved these changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@laysakura laysakura merged commit cecdb33 into main Jun 5, 2022
@laysakura laysakura deleted the switch_chrono_to_time branch June 5, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laysakura laysakura laysakura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrapping chrono
2 participants
@kazuk @laysakura