Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small typos #157

Merged
merged 2 commits into from
May 31, 2022
Merged

Small typos #157

merged 2 commits into from
May 31, 2022
+2 −2

Conversation

TrymDev
Copy link
Contributor

@TrymDev TrymDev commented May 21, 2022

@CLAassistant
Copy link

CLAassistant commented May 21, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #157 (b54107a) into main (8b2cbf8) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   87.79%   87.80%           
=======================================
  Files         203      203           
  Lines       12620    12620           
=======================================
+ Hits        11080    11081    +1     
+ Misses       1540     1539    -1
Impacted Files Coverage Δ
springql-core/src/pipeline/relation/sql_type.rs 89.65% <ø> (ø)
test-web-console-mock/src/lib.rs 92.45% <0.00%> (ø)
..._engine/autonomous_executor/row/value/sql_value.rs 75.51% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2cbf8...b54107a. Read the comment docs.

kazuk
kazuk approved these changes May 22, 2022
View reviewed changes
Copy link
Contributor

@kazuk kazuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TrymDev .

kazuk
kazuk suggested changes May 22, 2022
View reviewed changes
Copy link
Contributor

@kazuk kazuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add CHANGELOG like a bellow.

### Fixed

- Fix some typos ([#157](https://github.com/SpringQL/SpringQL/pull/157))

laysakura
laysakura approved these changes May 22, 2022
View reviewed changes
Copy link
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrymDev We appreciate your contribution.

Recently, we have changed CHANGELOG.md policy a bit.

https://github.com/SpringQL/SpringQL/blob/main/CHANGELOG.md

We originally added ### For developers sections in order to separate changes for end-users and developers. All other sections are for end-users.

You may feel free to add For developers section if you want.

Anyway, I approve this PR. I will merge this after your response or further commit on CHANGELOG.md.

@laysakura laysakura merged commit e15a4b8 into SpringQL:main May 31, 2022
@laysakura
Copy link
Contributor

No reply for 8 days. I merge this PR without CHANGELOG update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuk kazuk kazuk requested changes

@laysakura laysakura laysakura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TrymDev @CLAassistant @laysakura @kazuk