add fog_provider to carrierwave template #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when not including the config.fog_provider = 'fog/aws' starting the Rails application will result in the error .rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:292:in `require': cannot load such file -- fog (LoadError)
|
oh I am not sure why CI fails. This has nothing to do with my change I hope: |
|
Is this for when you use the fog-aws gem instead of the generic fog gem? |
|
yes I am using the |
|
Nice work 👍 |
|
Nice find, merging it. Small aside: we will try switching to ActiveStorage soon. CI is failing because of some weird issue in our tests, rebuilding it fixes it. |
|
@Bramjetten oh cool - ActiveStorage is nice. Thanks for the merge. It would be cool to have a section in the README about how to use S3. If I find a time slot I will send another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when not including the config.fog_provider = 'fog/aws' starting the Rails application will result in the error
.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:292:in `require': cannot load such file -- fog (LoadError)