Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No memoization for polymorphic AttrJson model #1196

Merged
merged 1 commit into from
Feb 12, 2023
Merged

No memoization for polymorphic AttrJson model #1196

merged 1 commit into from
Feb 12, 2023

Conversation

Bramjetten
Copy link
Contributor

Fixes #1190

@Bramjetten Bramjetten mentioned this pull request Feb 12, 2023
Closed
@Bramjetten Bramjetten changed the title No memoization for spina parts No memoization for polymorphic AttrJson model Feb 12, 2023
@Bramjetten Bramjetten merged commit 90a1edb into SpinaCMS:main Feb 12, 2023
@Bramjetten Bramjetten deleted the attrjson2_fix branch February 12, 2023 15:47
@dankmitchell
Copy link
Member

dankmitchell commented Feb 18, 2024 •
edited
Loading

@Bramjetten I've just come across this issue in Spina 2.0.1 when fixing the sorting... can I include this fix without having to bump to 2.14.0 ?

I've copied the file into the app under config/initializers/spina/attr_json_spina_parts_model.rb

Problem solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attr_json 2.0 causes AttrJson::Type::PolymorphicModel::TypeError in Spina::Pages#show
2 participants
@Bramjetten @dankmitchell