Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dependencies #590

Merged
merged 1 commit into from Oct 26, 2015
Merged

Fixed dependencies #590

merged 1 commit into from Oct 26, 2015

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@vinkla
Copy link
Contributor

vinkla commented Oct 26, 2015

👍

@patrickbrouwers
Copy link
Member

Brace yourself, the "Support 5.2 " issues are coming :( ;) Haha :)

(Edit. And yes, there are people who already try using it ;) #572)

patrickbrouwers added a commit that referenced this pull request Oct 26, 2015
@patrickbrouwers
Merge pull request #590 from GrahamCampbell/patch-1
587fdae 
Fixed dependencies
@patrickbrouwers patrickbrouwers merged commit 587fdae into SpartnerNL:master Oct 26, 2015
@GrahamCampbell GrahamCampbell deleted the patch-1 branch October 26, 2015 11:54
@GrahamCampbell
Copy link
Contributor Author

I'll send a PR to allow 5.2.x usage, but I recommend you only merge that at least after symfony 3 has been tagged.

@GrahamCampbell
Copy link
Contributor Author

Brace yourself, the "Support 5.2 " issues are coming :( ;) Haha :)

I doubt it. If someone asks composer for ~2.0 of this package, composer will resolve v2.0.9 because you marked it as compatible with all 5.x. That's going to be a pain in the future, for people thinking this works on Laravel 5.4, or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrahamCampbell @vinkla @patrickbrouwers