Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose_rpc macro works with Runtime #406

Merged
merged 12 commits into from
Jun 14, 2023
Merged

expose_rpc macro works with Runtime #406

merged 12 commits into from
Jun 14, 2023

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Jun 13, 2023 •
edited
Loading

Description

This PR introduces the following changes

  1. expose_rpc works on Runtime rather than StateTransitionRunner.
  2. Adds rpc_gen to Accounts, Sequencer, Bank

Linked Issues

Testing

No impact on tests.

Docs

Relevant docs updated.

@codecov
Copy link

codecov bot commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #406 (75fe27e) into main (d3f0d24) will decrease coverage by 0.1%.
The diff coverage is 94.5%.

Impacted Files Coverage Δ
...m/module-implementations/sov-accounts/src/query.rs 92.8% <0.0%> (-7.2%) ⬇️
...-implementations/sov-sequencer-registry/src/lib.rs 88.8% <ø> (ø)
...mplementations/sov-sequencer-registry/src/query.rs 82.6% <0.0%> (ø)
module-system/sov-modules-api/src/lib.rs 54.9% <ø> (ø)
...le-system/sov-modules-macros/src/rpc/expose_rpc.rs 98.7% <98.4%> (+2.6%) ⬆️
module-system/sov-modules-macros/src/lib.rs 98.0% <100.0%> (+0.1%) ⬆️

preston-evans98
preston-evans98 reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@preston-evans98 preston-evans98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would love to see a review from @dubbelosix before we merge since he's most familiar with this part of the codebase.

@bkolad bkolad changed the title expose rpc macro works with Runtime expose_rpc macro works with Runtime Jun 14, 2023
@bkolad bkolad marked this pull request as ready for review June 14, 2023 08:43
dubbelosix
dubbelosix approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@dubbelosix dubbelosix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bkolad bkolad merged commit 6287068 into main Jun 14, 2023
@bkolad bkolad deleted the blaze/expose_rpc_macro branch June 14, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preston-evans98 preston-evans98 preston-evans98 left review comments

@citizen-stig citizen-stig citizen-stig approved these changes

@dubbelosix dubbelosix dubbelosix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkolad @dubbelosix @citizen-stig @preston-evans98