Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http client config hooks interface #59

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Conversation

Crim
Copy link
Collaborator

@Crim Crim commented Aug 11, 2021

Provides an interface for modifying how the underlying HttpClient instance is created.

Usage of this would look like:

final RestClient restClient = new HttpClientRestClient(new HttpClientConfigHooks {
    // Override methods as needed to modify behavior.
});

// Create client, passing configuration and RestClient implementation
final KafkaConnectClient client = new KafkaConnectClient(configuration, restClient);

// Use client as normal...

@Crim
Copy link
Collaborator Author

Crim commented Aug 11, 2021

@MosheElisha Please see the above PR. I've added a more maintainable method for being able to override internal setup and configuration of the underlying HttpClient via a new interface.

I believe this should continue to be able to solve your use cases correct? If so I'll merge this and cut a release.

Thanks!

Copy link
Contributor

@MosheElisha MosheElisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@Crim Crim merged commit f16eb70 into master Aug 11, 2021
@Crim Crim deleted the spp/HttpClientConfigHooks branch August 11, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants