-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'min-acl' to let users determine the minimum access level to gene… #28
Conversation
…rate the documentation
For some reason, |
So I have tested with a SPM of my own and it works, but I cannot make it work with a Xcode project, sourcekitten seems to return and empty list of source files, while the direct EDIT: It seems that SourceDocs fails to generate the SourceKitten needed steps to work with Xcode projects that use SPM. |
So in the end was a problem with SourceKitten version, updated it, working like a charm. Ready to review |
Not sure why certain steps are failing on the CI (are passing fine on local) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you for your contribution, @minuscorp.
I had a much basic PR for adding support for open
ACL, but was failing too and haven't had a chance to look back into it. I'll run some tests on my end and see if we can figure out how to pass CI.
Thank you
|
||
static func == (lhs: AccessLevel, rhs: AccessLevel) -> Bool { | ||
return lhs.priority == rhs.priority | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty cool, nice idea!
As far as I've tested, this works fine on SPM modules and Xcode projects (the failure was because the outdated Sourcekitten dependency, which ironically makes the build to fail on the CI but not on local 🤷♂ ) |
I think that the issue with the CI can be the usage of a pretty old Xcode image, I world try to bump it at least to Xcode 10, that has support for Swift 5. I think that SourceKitten recently upgraded its minimum Swift version. Giving it a shot doesn't hurt anybody, will try tomorrow. |
Updated the Travis workflow, minimum toolchain needed is Swift 5.0 (SourceKitten) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a couple of changes for better code standards.
Have a spare week, want me to dive to finish this and make a release? @eneko |
…rate the documentation
Breaking
Enhancements
min-acl
parameter that allowsprivate | fileprivate | internal | public | open
options, defaults topublic
as for now.Bug Fixes