Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAR-6673 Do not try to load DefaultNotificationManager in preview mode #403

Merged
merged 1 commit into from
Jul 13, 2015

Conversation

henryju
Copy link
Member

@henryju henryju commented Jun 30, 2015

No description provided.

@simonbrandhof
Copy link
Contributor

@henryju this PR does not make sense anymore. NotificationManager is already on server side only.

@SonarTech
Copy link
Collaborator

SonarQube analysis reported 6 issues:

  • CRITICAL 1 critical
  • MAJOR 5 major

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

@henryju
Copy link
Member Author

henryju commented Jul 13, 2015

@simonbrandhof The point is to fix the issue in SQ 5.1...

henryju added a commit that referenced this pull request Jul 13, 2015
…eview

SONAR-6673 Do not try to load DefaultNotificationManager in preview mode
@henryju henryju merged commit 1fbd4fc into branch-5.1 Jul 13, 2015
@henryju henryju deleted the feature/fix_notif_manager_preview branch July 13, 2015 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants