Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARJAVA-3072 Removal of 'File' to rely on 'InputFile' #2474

Merged
merged 2 commits into from
Apr 3, 2019
Merged

SONARJAVA-3072 Removal of 'File' to rely on 'InputFile' #2474

merged 2 commits into from
Apr 3, 2019

Conversation

m-g-sonar
Copy link

No description provided.

@m-g-sonar m-g-sonar force-pushed the SONARJAVA-3072 branch 5 times, most recently from 0944f91 to 90c6333 Compare April 2, 2019 16:56
saberduck
saberduck reviewed Apr 3, 2019
View reviewed changes
java-frontend/src/test/java/org/sonar/java/TestUtils.java Outdated
.setLanguage("java")
.build();
} catch (Exception e) {
throw new IllegalStateException(String.format("Unable to lead file '%s", file.getAbsolutePath()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "lead" -> "read"

saberduck
saberduck approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@saberduck saberduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I pushed one small typo fix.

@saberduck saberduck merged commit 2484c4d into master Apr 3, 2019
@saberduck saberduck deleted the SONARJAVA-3072 branch April 3, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saberduck saberduck saberduck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-g-sonar @saberduck @Wohops