-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TikTok username optional based on scopes set #1183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
I got approved and added this scope, but I still can't see the username. |
@atymic I debugged this: the username field isn't being passed to the fields list when the scope was added. Was this tested before merging? |
@liamseys can you share the scopes you're using in laravel? |
|
When I print |
In v2,
username
can be requested only ifuser.info.profile
scope is set.Instead of forcing the scope, since it's not even in the default list of scopes set in the provider, we could just add the username field if the scope is present.
Closes #1198