Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bridge config after merge #860

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Update bridge config after merge #860

merged 4 commits into from
Jun 15, 2023

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Jun 14, 2023 •
edited
Loading

Resolves: SNO-512
Cumulus companion: Snowfork/cumulus#35

@alistair-singh alistair-singh mentioned this pull request Jun 14, 2023
Merged
@codecov
Copy link

codecov bot commented Jun 14, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (65450c1) 64.44% compared to head (a95efc9) 64.44%.

❗ Current head a95efc9 differs from pull request most recent head 534bd76. Consider uploading reports for the commit 534bd76 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #860   +/-   ##
=======================================
  Coverage   64.44%   64.44%           
=======================================
  Files          10       10           
  Lines         225      225           
  Branches       52       52           
=======================================
  Hits          145      145           
  Misses         60       60           
  Partials       20       20

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alistair-singh alistair-singh marked this pull request as ready for review June 14, 2023 22:34
@alistair-singh alistair-singh requested review from yrong and vgeddes June 15, 2023 10:31
vgeddes
vgeddes approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

yrong
yrong approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alistair-singh alistair-singh force-pushed the alistair/fix-bridge-config branch from 3a6674f to a95efc9 Compare June 15, 2023 19:45
@alistair-singh alistair-singh mentioned this pull request Jun 15, 2023
Merged
@alistair-singh alistair-singh merged commit f48605c into main Jun 15, 2023
@alistair-singh alistair-singh deleted the alistair/fix-bridge-config branch June 15, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doubledup doubledup doubledup approved these changes

@yrong yrong yrong approved these changes

@vgeddes vgeddes vgeddes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alistair-singh @vgeddes @yrong @doubledup