Switch to foundry monthly release for 2023-06 #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The foundry overlay updated its monthly branch yesterday to include e48d. This was needed to fix some test failures, but merged on 2023-05-05 after the last monthly release. Switching to monthly releases means we don't need to keep bumping the nightly version every few days to make builds on new machines work.
New machines failed to build after a few days because Foundry only keeps the last 3 nightly release builds. New machines don't have the locked Foundry version cached and can't fetch them once Foundry's deleted them.
Also, Foundry sometimes built nightly >=3 times in 1 day, so any fresh machine wouldn't work until the next overlay build. This is the issue @claravanstaden ran into, and won't happen when using monthly releases.