SNO-305: Ethereum -> Parachain: bundle messages by address #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Track nonces by source address * Remove principal from basic outbound channel * Update relayer bindings * Track nonces by origin address * Fix outbound channel tests
* Add origin field to message decoding * Track nonces by message origin * Include origin address in basic channel message id * Update basic inbound fixture data * Add note about updating inbound channel test data * Mention message data encoding in comment * Update test data in envelope test * Remove channel id from message id * s/origin/user/g * Swap the order of source & user * Reword test data generation section * s/value/nonce * Use named fields in MessageId enum * Switch to Twox64Concat hasher This prevents accidental expensive lookups while remaining relatively fast vs Blake2_128 and resistant to attacks that cause prefix collisions, thanks to the security of keccak used to create the Ethereum address. * Remove rogue print statement
* Remove redundant slice * Add initial address filtering * Remove extra nonce var * Clean up basic channel address config * Rename parachain relayer account config * Remove unused method * Fix up comments * Add default eth addresses for basic channel * Improve map log readability * Fix parachain writer error messages * Bump lodestar version in example command * Switch to default eth account for E2E script
This helps with some of the longer running tests that are timing out when given 400s.
doubledup
requested review from
vgeddes,
claravanstaden,
alistair-singh and
a team
|
Thanks David, looks good! Will review properly tomorrow or early next week. In any case lets hold off on merging this until after our demo on Monday. I think some of Clara's fixes in #696 may help with reliability. If not we should do a peer session together and see why those ERC20 tests are so troublesome. |
vgeddes
reviewed
Oct 14, 2022
This was referenced Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this now because some tests are passing in both directions, while the others are timing out. The Basic Channel, Bootstrap and DOT App tests are passing. I haven't seen all of the tests pass yet, but I've been getting timeouts & closed connections with no errors in the logs. The ERC20 App tests in particular look like they're not terminating - running the tests on main now to compare with this branch.
Bumped the default timeout in the E2E test command to 25 mins, up from 6m 40s. This seems to be enough for the tests that have terminated. For the run on main, I'm trying a timeout of 2 hours to ensure that the tests have enough time.