Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Polkadot dependencies to v0.9.25 #669

Merged
merged 26 commits into from
Aug 15, 2022
Merged

Upgrade Polkadot dependencies to v0.9.25 #669

merged 26 commits into from
Aug 15, 2022

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Aug 4, 2022 •
edited
Loading

Resolves: SNO-299

Changelog

  1. transactional is deprecated because it is now the default behaviour. I have left transactions in however because it is un-deprecated in release v0.9.27
  2. AccountIdConversion has remove into_account() method.
    1. In places where into_account is used in a runtime context I have replaced it with try_into_account and added runtime checks.
    2. In places where into_account is used for initialisation or configuration(export genesis state, wasm) I have replaced it with try_into_account and panic on failure.
    3. In mocks and tests I have replaced it with into_account_truncating.
  3. Replaced json_rpc with jsonrpsee.
  4. cargo update
  5. Replaced custom export-genesis-state and export-genesis-wasm commands with built in versions.
  6. Use EitherOfDiverse instead of deprecated EnsureOneOf.
  7. Added support for hardware benchmarking.
  8. Updated polkadot-launch to 2.2.1
  9. Updated rust toolchain to stable-2022-07-19
    • stable: 1.61
    • nightly: 1.62.0-nightly
  10. Re-enabled test github workflow.
  11. Also updated the snowbridge-test-node to v0.9.25.

TODO

  • Run E2E tests

@vgeddes
Copy link
Collaborator

vgeddes commented Aug 5, 2022

Ah cool. Are there some release notes or documentation somewhere explaining the deprecation of transactional?

@alistair-singh
Copy link
Contributor Author

Ah cool. Are there some release notes or documentation somewhere explaining the deprecation of transactional?

It has been marked as deprecated because this is the default behavior for all extrinsics. However it seems to be un-deprecated in the PR below which is included in v0.9.27 so I will revert that commit.

https://github.com/paritytech/substrate/pull/11807/files#diff-55fa2bbcb98405e03a4311fca1d14b211001133cffa61fb0d4837be69c9e7bebL432

@alistair-singh alistair-singh marked this pull request as ready for review August 12, 2022 15:56
@alistair-singh alistair-singh requested a review from a team August 12, 2022 15:56
@alistair-singh alistair-singh force-pushed the alistair/upgrade-to-v0.9.25 branch from bddccbc to dcccc2c Compare August 12, 2022 15:57
vgeddes
vgeddes approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@alistair-singh
update to v0.9.25
3d37710
@alistair-singh
Remove deprecated transactional statements. This is now default behav…
fda6d4a 
…ior.
@alistair-singh
remove transaction imports
add0197
@alistair-singh
fixed account id conversions
43612ae
@alistair-singh
Removed deprecated EnsureOneOf
8fdac10
@alistair-singh
runtime upgrades
08eb6c3
@alistair-singh
Fixed build errors
3b2ee48
@alistair-singh
panic instead of truncating accounts on conversion
aa60f59
@alistair-singh
Revert "Remove deprecated transactional statements. This is now defau…
1198f84 
…lt behavior."

This reverts commit 3c10324.
@alistair-singh
Revert "remove transaction imports"
5e52719 
This reverts commit a112dbc.
@alistair-singh
changed order
3d267ef
@alistair-singh
updated rust runtime
7460794
@alistair-singh
updated runtime
b9e5e8d
@alistair-singh
updated readme
3ec1697
@alistair-singh
re-enable tests
cb3d36f
@alistair-singh
rustfmt
ec7f20c
@alistair-singh
updated test parachain
703bd9a
@alistair-singh
upgraded test parachain
777d89d
@alistair-singh
fixed cmd line args
0367819
@alistair-singh
excluded runtimes
89615f7
@alistair-singh
cargo update
649d72c
@alistair-singh
update polkadot launch
f79b055
@alistair-singh
downgraded tracing to fix logging
5222994
@alistair-singh
update metadata
64bdb0e
@alistair-singh alistair-singh force-pushed the alistair/upgrade-to-v0.9.25 branch from dcccc2c to 4ac3516 Compare August 15, 2022 19:07
@alistair-singh alistair-singh merged commit 5ceed3c into main Aug 15, 2022
@alistair-singh alistair-singh deleted the alistair/upgrade-to-v0.9.25 branch August 15, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgeddes vgeddes vgeddes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alistair-singh @vgeddes