Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sno 136 v0.9.12 upgrade #534

Merged
merged 31 commits into from
Nov 15, 2021
Merged

Sno 136 v0.9.12 upgrade #534

merged 31 commits into from
Nov 15, 2021

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Nov 4, 2021 •
edited
Loading

Resolves: https://linear.app/snowfork/issue/SNO-136/parachain-xcm-v3-support

  • Added new constants. To choose these I just eyeballed common settings for non test/mock code using github code search.
    1. OperationalFeeMultiplier is 5.
    2. MaxInstructions is 100.
    3. VERSION_DISCOVERY_QUEUE_SIZE is 100.
    4. AdvertisedXcmVersion is currently set to 3 and probably should be 1.
    5. MaxAuthorities is 32.
    6. force_unreserve default weight is 54_482_000.
  • I chose to ignore some change sets from the parachain template:
    1. Removing pallet-randomness-collective-flip crate.
    2. Adding sc-transaction-pool-api crate. code
    3. Adding ss58Format to chain_spec properties. code
    4. Choosing not to handle AssetTrap and AssetClaims (Leaving it set to ()). Template uses PolkadotXcm. code
    5. New constraints on start_node_impl. code
		+ pallet_transaction_payment_rpc::TransactionPaymentRuntimeApi<Block, Balance>
		+ substrate_frame_rpc_system::AccountNonceApi<Block, AccountId, Nonce>,
  • start-services.sh works after updating @polkadot/api to 6.8.1 because of new metadata format.
    1. Relayers fail with ”unsupported metadata version 14" because GRPC support is TDB. This means e2e tests cannot be run yet.

I am going to upgrade XCM in a follow up commit as this one is a bit large.

vgeddes
vgeddes reviewed Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I've reviewed and found a few things, besides my other comments:

  • The #[pallet::metadata()] macro has been deprecated and should no longer be used to decorate pub enum Event in pallets.
  • When implementing the frame_system::Config trait in the runtimes and mocks for tests, the BaseCallFilter type should be frame_support::traits::Everything instead of ().
  • The MessageId type in the primitives/core library should have TypeInfo implemented.
  • In all crates that depend on serde and codec, bump the versions as follows to match Substrate:
serde = { version = "1.0.130", optional = true }
codec = { version = "2.2.0", package = "parity-scale-codec", default-features = false, features = ["derive"] }

parachain/pallets/dispatch/src/lib.rs Outdated Show resolved Hide resolved
@alistair-singh alistair-singh marked this pull request as ready for review November 15, 2021 10:55
vgeddes
vgeddes approved these changes Nov 15, 2021
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Lets get this merged in.

I'm OK with E2E tests not working until GSRPC has been upgraded with Metadata 14. This doesn't block us in any way though, since we can still build previous versions of the blockchain for local and staging.

@alistair-singh alistair-singh merged commit 7dd4529 into main Nov 15, 2021
@alistair-singh alistair-singh deleted the sno-136-v0.9.12-upgrade branch November 15, 2021 12:58
@vgeddes vgeddes mentioned this pull request Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgeddes vgeddes vgeddes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alistair-singh @vgeddes