Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to Polkadot v0.9.8 #462

Merged
merged 18 commits into from
Jul 21, 2021
Merged

Update dependencies to Polkadot v0.9.8 #462

merged 18 commits into from
Jul 21, 2021

Conversation

vgeddes
Copy link
Collaborator

@vgeddes vgeddes commented Jul 21, 2021

No description provided.

@vgeddes vgeddes requested a review from philipstanislaus July 21, 2021 07:39
vgeddes and others added 16 commits July 21, 2021 07:54
@vgeddes
Implement pallet_randomness_collective_flip::Config for runtimes
9576ee1
@philipstanislaus
fix: validate_transaction missing arguments
0da1c71
@vgeddes
Fixes
c5372dc
@vgeddes
Merge branch 'collab-session' of https://github.com/Snowfork/snowbridge…
883b5f1 
… into collab-session
@philipstanislaus
fix: add missing weights for balances pallet transfer_all function
26e75ce
@philipstanislaus
Merge branch 'collab-session' of github.com:Snowfork/polkadot-ethereu…
3cff488 
…m into collab-session
@vgeddes
Update trait config for pallet balances
ee62669
@vgeddes
Merge branch 'collab-session' of https://github.com/Snowfork/snowbridge…
86a1ed2 
… into collab-session
@vgeddes
Add CheckInherents to register_validate_block
2b8fee2
@philipstanislaus
fix: compilation of parachain/src/service.rs
09d8dac
@vgeddes
Update more things
2c4630d
@vgeddes
Update polkadot-js
3f13061
@musnit
log improvements
7da320a
@musnit
change blake2b to kekkak (#465)
b24b919
@musnit
contract addr fixes
eae6407
@vgeddes
Fix benchmarking compilation errors
adf2028
@vgeddes vgeddes marked this pull request as ready for review July 21, 2021 14:36
@vgeddes vgeddes merged commit 64b1fbb into main Jul 21, 2021
@vgeddes vgeddes deleted the collab-session branch July 21, 2021 17:04
philipstanislaus
philipstanislaus reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@philipstanislaus philipstanislaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one question below 👇

🙏

parachain/runtime/local/src/lib.rs
_ => false,
}
fn filter(_: &Call) -> bool {
true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended?

parachain/runtime/rococo/src/lib.rs
_ => false,
}
fn filter(_: &Call) -> bool {
true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linewise

parachain/runtime/snowbridge/src/lib.rs
_ => false,
}
fn filter(_: &Call) -> bool {
true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipstanislaus philipstanislaus philipstanislaus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgeddes @philipstanislaus @musnit