chore: Apply new resource conventions to scim integration #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jmichalak
requested changes
Jun 27, 2024
|
Integration tests failure for 114cf3d01aa3b50aff562a302674feeb7f911fec |
sfc-gh-jcieslak
force-pushed
the
scim-integration-apply-conventions
branch
from
8fb8fe1
to
c5ecb77
Compare
|
Integration tests failure for 8fb8fe1d3b36ddd3ebb1bafe641c58ed78c9a7cd |
|
Integration tests failure for c5ecb7755a36aa21ae08c91aeac5e83cafaa617f |
|
Integration tests failure for aebfbde6da5e6119597846b44d6052438fb306ae |
sfc-gh-jmichalak
approved these changes
Jun 28, 2024
sfc-gh-asawicki
approved these changes
Jun 28, 2024
|
|
||
| func v091ScimIntegrationStateUpgrader(ctx context.Context, rawState map[string]interface{}, meta interface{}) (map[string]interface{}, error) { | ||
| func v091ScimIntegrationStateUpgrader(ctx context.Context, rawState map[string]any, meta any) (map[string]any, error) { |
There was a problem hiding this comment.
change that name pls (next PR is fine)
There was a problem hiding this comment.
I was already changed in the SAML pr
| planchecks.ExpectChange("snowflake_scim_integration.test", "scim_client", tfjson.ActionUpdate, sdk.String("GENERIC"), sdk.String("GENERIC")), | ||
| planchecks.ExpectChange("snowflake_scim_integration.test", "run_as_role", tfjson.ActionUpdate, sdk.String(role.Name()), sdk.String(role.Name())), | ||
| planchecks.ExpectChange("snowflake_scim_integration.test", "network_policy", tfjson.ActionUpdate, sdk.String(""), sdk.String("")), | ||
| planchecks.ExpectChange("snowflake_scim_integration.test", "sync_password", tfjson.ActionUpdate, nil, sdk.String("unknown")), |
There was a problem hiding this comment.
Please check (in the next PR) if we can avoid having a change by adding an unknown in the upgrader if the key was not present in the previous state at all. EDIT: after discussion, I will check it with other options in my PR.
| @@ -9,6 +9,10 @@ across different versions. | |||
| Following the [announcement](https://github.com/Snowflake-Labs/terraform-provider-snowflake/discussions/2736) we have removed the old grant resources. The two resources [snowflake_role_ownership_grant](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/role_ownership_grant) and [snowflake_user_ownership_grant](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/user_ownership_grant) were not listed in the announcement, but they were also marked as deprecated ones. We are removing them too to conclude the grants redesign saga. | |||
|
|
|||
| ### snowflake_scim_integration resource changes | |||
| #### *(behavior change)* Changed behavior of `sync_password` | |||
There was a problem hiding this comment.
should we also add info about expected changes after bumping version? (because of the state handling changes - consult warehouse) - next Pr is fine
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jul 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.93.0](v0.92.0...v0.93.0) (2024-07-10) ### 🎉 **What's new:** * Add OAUTH integration for custom clients ([#2908](#2908)) ([d9b557f](d9b557f)) * Add oauth integration for partner applications ([#2912](#2912)) ([91788e5](91788e5)) * Add support for cortex search service ([#2860](#2860)) ([43aa89f](43aa89f)) * API Authentication integration v1 readiness ([#2898](#2898)) ([91931da](91931da)) * External Oauth integration v1 readiness ([#2907](#2907)) ([ed237c3](ed237c3)) * Generate show outputs with mappers ([#2886](#2886)) ([1cada88](1cada88)) * Introduce security integrations datasource ([#2892](#2892)) ([7f6c657](7f6c657)) * SAML2 integration v1 readiness ([#2868](#2868)) ([d0c136d](d0c136d)) * SCIM integration v1 readiness ([#2846](#2846)) ([269df6b](269df6b)) * Security integrations datasource v1 readiness ([#2913](#2913)) ([d10474a](d10474a)) * standard database v1 readiness ([#2842](#2842)) ([3c11953](3c11953)) * Warehouse redesign final touches ([#2900](#2900)) ([0eab636](0eab636)) * Warehouse redesign part1 ([#2864](#2864)) ([6664457](6664457)) * Warehouse redesign part2 ([#2887](#2887)) ([1aaf417](1aaf417)) * Warehouse redesign part3 ([#2890](#2890)) ([873a1ed](873a1ed)) * Warehouse redesign part4 ([#2893](#2893)) ([d525fd9](d525fd9)) ### 🔧 **Misc** * Add documentation on unset and defaults ([#2882](#2882)) ([85a7836](85a7836)) * apply minor database changes ([#2872](#2872)) ([6ccac59](6ccac59)) * Apply new resource conventions to scim integration ([#2891](#2891)) ([e11e608](e11e608)) * Improve generator template organization ([#2820](#2820)) ([5035e2f](5035e2f)) * Nuke stale objects ([#2869](#2869)) ([9c4a117](9c4a117)) * Show a possible solution for [#2877](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2877) ([#2878](#2878)) ([6fb437b](6fb437b)) * Validations cleanup and old grants removal ([#2884](#2884)) ([05b7eee](05b7eee)) ### 🐛 **Bug fixes:** * Add disclaimers and fix tests ([#2905](#2905)) ([1deaedc](1deaedc)) * Fix cortex search service ([#2904](#2904)) ([763d06c](763d06c)) * use suppressQuoting to fix stage file_format permadiff ([#2885](#2885)) ([fd70f6e](fd70f6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done in the PR:
sync_password)