feat: Upgrade stream sdk #3105
Merged
feat: Upgrade stream sdk #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 71a87b70a29afeafa3981e7586a5ac623d905099 |
|
Integration tests failure for ee076b8ce3bc852cc8721b6fe25837c6ee2be7c4 |
| HasSchemaName(id.SchemaName()). | ||
| HasComment("some comment"). | ||
| HasSourceType("Table"). | ||
| HasMode("APPEND_ONLY"). |
There was a problem hiding this comment.
are there any enums for sourceType and mode? Asserts could be extended to use them
There was a problem hiding this comment.
These will be added in the next PR.
|
Integration tests cancelled for faf87ff0051195b154f6075c5e0b435eff3db474 |
sfc-gh-jcieslak
approved these changes
Sep 30, 2024
|
Integration tests failure for c6973732317bfeb78e468ed860b85041c852d472 |
| "github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk" | ||
| ) | ||
|
|
||
| func (s *StreamAssert) HasTableId(expected string) *StreamAssert { |
There was a problem hiding this comment.
nit: why string and to schemaobjectidentifier here as input?
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Oct 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.97.0](v0.96.0...v0.97.0) (2024-10-10) ### 🎉 **What's new:** * Add secret to sdk ([#3091](#3091)) ([7430aee](7430aee)) * Add service user and legacy service user resources ([#3119](#3119)) ([0e88e08](0e88e08)) * Handle all Task parameters in SDK ([#3103](#3103)) ([08ae072](08ae072)) * Stream on external table resource ([#3122](#3122)) ([d837341](d837341)) * Stream on table resource ([#3109](#3109)) ([97fa9b4](97fa9b4)) * Tasks v1 readiness - SDK part ([#3086](#3086)) ([0a77383](0a77383)) * Upgrade stream sdk ([#3105](#3105)) ([ad5fa11](ad5fa11)) ### 🔧 **Misc** * Add pre check to each datasource ([#3065](#3065)) ([560ab6b](560ab6b)) * Bump golang-ci lint to 1.61 ([#3112](#3112)) ([f23e085](f23e085)) * Secret Validation change ([#3111](#3111)) ([666630e](666630e)) ### 🐛 **Bug fixes:** * Fix parsing text in view, check parenthesis in ParseSchemaObjectIdentifierWithArguments ([#3102](#3102)) ([b0a67e6](b0a67e6)) * Try to reproduce 2679 and 3117 ([#3124](#3124)) ([ccdbc30](ccdbc30)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
References
https://docs.snowflake.com/en/sql-reference/sql/create-stream
TODO
Adjust SHOW field types. Add new resources for each type of stream. Adjust stream data source.