Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up old test object helpers #3049

Merged
merged 22 commits into from
Sep 10, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Sep 6, 2024

  • remove old helpers (testDb, testSchema, testWarehouse)
  • use TestClient instead of Client in the acceptance tests
  • add missing helpers
  • add missing helper methods
  • move grant helpers from role client to grant client

Copy link

github-actions bot commented Sep 6, 2024

Integration tests failure for 84e8bec70e4970c66f0c8d0eb1d222b69596ed3a

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review September 6, 2024 12:18
sfc-gh-jcieslak
sfc-gh-jcieslak previously approved these changes Sep 9, 2024
pkg/resources/unsafe_execute_acceptance_test.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 9, 2024

Integration tests failure for 49c4e27a96f37ecdf677a3c51d39ece3e747d68d

@sfc-gh-asawicki sfc-gh-asawicki merged commit 78ecb62 into main Sep 10, 2024
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the clean-up-old-test-object-helpers branch September 10, 2024 06:48
sfc-gh-jmichalak pushed a commit that referenced this pull request Sep 19, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.96.0](v0.95.0...v0.96.0)
(2024-09-18)

Essential GA object readiness for V1:
[link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD)
([Roadmap
reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#preparing-essential-ga-objects-for-the-provider-v1)).

:exclamation: Migration guide: [v0.95.0 ->
v0.96.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0950--v0960)

### 🎉 **What's new:**

* V1 redesign of resources and data sources
* Row access policy
([#3066](#3066))
([#3063](#3063))
* Resource monitor
([#3052](#3052))
([#3064](#3064))
* Masking policy
([#3078](#3078))
([#3083](#3083))
* SDK upgrades
* External volume
([#3033](#3033))
* Authentication policy
([#2937](#2937))
([#3068](#3068))
([#3061](#3061))


### 🔧 **Misc**

* Clean up old test object helpers
([#3049](#3049))
* Add example of granting role to multiple objects
([#3047](#3047))
* Update readme and objects rework state
([#3046](#3046))

### 🐛 **Bug fixes:**

* Fix model grants
([#3070](#3070))
* Fix database show by and resource logic
([#3055](#3055))
* Fix default secondary roles option import
([#3041](#3041))
* Fix sweepers for warehouse and database
([#3057](#3057))
* Fix views permadiff
([#3079](#3079))
* Update v0.95.0 migration guide
([#3062](#3062))

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants