chore: Add annotation about fully_qualified_name and fix handling granteeName #3009

sfc-gh-jmichalak · 2024-08-20T15:38:25Z

add a new guide for identifiers
add a note about using object references if you don't manage referenced objects
fix a typo in one of the examples
improve handling database role grants with a test for mixed case

Test Plan

acceptance tests

…e in grants

github-actions · 2024-08-20T16:54:30Z

Integration tests failure for 00461eec6b0838ca98c86847bad02cfd5c58eaa9

github-actions · 2024-08-21T09:14:41Z

Integration tests failure for f2df1d8e7f6c0211643af0158438b226b7dabb77

docs/guides/identifiers.md

sfc-gh-asawicki · 2024-08-21T10:41:19Z

docs/resources/account_password_policy_attachment.md

@@ -23,6 +24,8 @@ resource "snowflake_account_password_policy_attachment" "attachment" {
 }
 ```

+-> **Note** If you don't manage password policy in Terraform, you can construct the proper id yourself, consult [identifiers guide](../guides/identifiers#new-computed-fully-qualified-name-field-in-resources)


please remember to validate this link after the release

Sure, I'll comment in this thread.

Right now it points to the repository markdown, maybe it should point the registry documentation?

but after release it should behave correctly (it's a relative URL, so it will point to the registry)

But it still needs to be validated :)

templates/resources/grant_privileges_to_account_role.md.tmpl

templates/resources/stream.md.tmpl

sfc-gh-jcieslak · 2024-08-21T11:24:51Z

docs/guides/identifiers.md

+
+If you don't manage table in Terraform, you can construct the proper id yourself like before:  `"\"database_name\".\"schema_name\".\"table_name\""`
+
+<!--- TODO: fill the rest of the document -->


What will go in here?

The rest of the document about identifiers rework.

sfc-gh-jcieslak · 2024-08-21T11:26:02Z

docs/resources/account_password_policy_attachment.md

@@ -23,6 +24,8 @@ resource "snowflake_account_password_policy_attachment" "attachment" {
 }
 ```

+-> **Note** If you don't manage password policy in Terraform, you can construct the proper id yourself, consult [identifiers guide](../guides/identifiers#new-computed-fully-qualified-name-field-in-resources)


Right now it points to the repository markdown, maybe it should point the registry documentation?

pkg/resources/grant_database_role.go

pkg/sdk/grants_impl.go

templates/resources/stream.md.tmpl

github-actions · 2024-08-21T13:34:13Z

Integration tests failure for ab6ee6cea64f4082dd338e97412a18d3f2cff7ff

github-actions · 2024-08-21T13:41:22Z

Integration tests failure for d2df50e66af82ce8f3fc218da3c456a8b58de862

github-actions · 2024-08-21T15:07:31Z

Integration tests failure for 2a9c3f72f8dfaf90796acad35cfcfc4c9536f89d

templates/resources/grant_ownership.md.tmpl

pkg/sdk/grants_impl.go

github-actions · 2024-08-22T13:49:22Z

Integration tests failure for 42c32716b20cc1b53ab2b90bbd0691a5618bcdc6

🤖 I have created a release *beep* *boop* --- ## [0.95.0](v0.94.1...v0.95.0) (2024-09-04) ### 🎉 **What's new:** * Add change_tracking, row access policy and aggregation policy to views ([#2988](#2988)) ([1f88bb1](1f88bb1)) * Add fully_qualified_name to all resources ([#2990](#2990)) ([1b0462f](1b0462f)) * Add identifier parsers ([#2957](#2957)) ([824ec52](824ec52)) * Add identifier with arguments ([#2979](#2979)) ([00ae1c5](00ae1c5)) * Add timeouts block to cortex ([#3004](#3004)) ([34d764b](34d764b)) * Add user parameters to resource ([#2968](#2968)) ([f4ae380](f4ae380)) * Conclude user rework ([#3036](#3036)) ([23e4625](23e4625)) * database role v1 readiness ([#3014](#3014)) ([c4db255](c4db255)) * Identifier with arguments for procedure and external function ([#2987](#2987)) ([f13cc5c](f13cc5c)) * Rework user resource ([#3026](#3026)) ([bde2638](bde2638)), closes [#1572](#1572) * Rework users datasource ([#3030](#3030)) ([751239b](751239b)), closes [#2902](#2902) * Upgrade view sdk ([#2969](#2969)) ([ef2d50a](ef2d50a)) * View rework part 2 ([#3021](#3021)) ([e05377d](e05377d)) * View rework part 3 ([#3023](#3023)) ([195b41c](195b41c)) ### 🔧 **Misc** * Add annotation about fully_qualified_name and fix handling granteeName ([#3009](#3009)) ([94e6345](94e6345)) * Apply identifier conventions ([#2996](#2996)) ([5cbea84](5cbea84)) * apply identifier conventions to grants ([#3008](#3008)) ([d7780ae](d7780ae)) * Clean collection utils ([#3028](#3028)) ([426ddb1](426ddb1)) * Clean old assertions ([#3029](#3029)) ([ad657eb](ad657eb)) * Conclude identifiers rework ([#3011](#3011)) ([c1b53f3](c1b53f3)) * Improve user test and add manual test for user default database and role ([#3035](#3035)) ([6cb0b4e](6cb0b4e)) * Use new identifier with arguments in function, external function and procedure grants ([#3002](#3002)) ([5053f8b](5053f8b)) * User improvements ([#3034](#3034)) ([65b64d7](65b64d7)) ### 🐛 **Bug fixes:** * database tests and introduce a new parameter ([#2981](#2981)) ([3bae7f6](3bae7f6)) * Fix custom diffs for fields with diff supression ([#3032](#3032)) ([2499602](2499602)) * Fix default secondary roles after BCR 2024_07 ([#3040](#3040)) ([2ca465a](2ca465a)), closes [#3038](#3038) * Fix issues 2972 and 3007 ([#3020](#3020)) ([1772387](1772387)) * Fix known user resource issues ([#3013](#3013)) ([a5dfeac](a5dfeac)) * identifier issues ([#2998](#2998)) ([6fb76b7](6fb76b7)) * minor issues ([#3027](#3027)) ([467b06e](467b06e)), closes [#3015](#3015) [#2807](#2807) [#3025](#3025) * Nuke users ([#2971](#2971)) ([0d90cc9](0d90cc9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

Add annotation about fully_qualified_name and fix handling granteeNam…

00461ee

…e in grants

Cleanup

f2df1d8

sfc-gh-jmichalak marked this pull request as ready for review August 21, 2024 08:00

sfc-gh-jmichalak requested review from sfc-gh-jcieslak and sfc-gh-asawicki August 21, 2024 08:00

sfc-gh-asawicki previously approved these changes Aug 21, 2024

View reviewed changes

sfc-gh-jcieslak reviewed Aug 21, 2024

View reviewed changes

sfc-gh-jmichalak added 2 commits August 21, 2024 14:15

Review suggestions

6388055

Merge remote-tracking branch 'origin/main' into id-followup

ab6ee6c

sfc-gh-jmichalak dismissed sfc-gh-asawicki’s stale review via ab6ee6c August 21, 2024 12:15

Revert new test

d2df50e

sfc-gh-jmichalak added 2 commits August 21, 2024 15:43

Fix mixed quotes

6a679af

Fix docs

2a9c3f7

sfc-gh-jcieslak reviewed Aug 22, 2024

View reviewed changes

templates/resources/grant_ownership.md.tmpl Outdated Show resolved Hide resolved

pkg/sdk/grants_impl.go Show resolved Hide resolved

Apply the note to all resources

42c3271

sfc-gh-jcieslak approved these changes Aug 22, 2024

View reviewed changes

sfc-gh-asawicki approved these changes Aug 22, 2024

View reviewed changes

sfc-gh-asawicki merged commit 94e6345 into main Aug 22, 2024
8 of 9 checks passed

sfc-gh-asawicki deleted the id-followup branch August 22, 2024 14:24

snowflake-release-please bot mentioned this pull request Aug 22, 2024

chore(main): release 0.95.0 #2977

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add annotation about fully_qualified_name and fix handling granteeName #3009

chore: Add annotation about fully_qualified_name and fix handling granteeName #3009

sfc-gh-jmichalak commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024

github-actions bot commented Aug 21, 2024

sfc-gh-asawicki Aug 21, 2024

sfc-gh-jmichalak Aug 21, 2024

sfc-gh-jcieslak Aug 21, 2024

sfc-gh-asawicki Aug 21, 2024

sfc-gh-jmichalak Aug 21, 2024

sfc-gh-jcieslak Aug 21, 2024

sfc-gh-jmichalak Aug 21, 2024

sfc-gh-jcieslak Aug 21, 2024

github-actions bot commented Aug 21, 2024

github-actions bot commented Aug 21, 2024

github-actions bot commented Aug 21, 2024

github-actions bot commented Aug 22, 2024


		If you don't manage table in Terraform, you can construct the proper id yourself like before: `"\"database_name\".\"schema_name\".\"table_name\""`

		<!--- TODO: fill the rest of the document -->

chore: Add annotation about fully_qualified_name and fix handling granteeName #3009

chore: Add annotation about fully_qualified_name and fix handling granteeName #3009

Conversation

sfc-gh-jmichalak commented Aug 20, 2024 • edited Loading

Test Plan

github-actions bot commented Aug 20, 2024

github-actions bot commented Aug 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 21, 2024

github-actions bot commented Aug 21, 2024

github-actions bot commented Aug 21, 2024

github-actions bot commented Aug 22, 2024

sfc-gh-jmichalak commented Aug 20, 2024 •

edited

Loading