Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust user SDK #2947

Merged
merged 16 commits into from
Jul 22, 2024
Merged

feat: Adjust user SDK #2947

merged 16 commits into from
Jul 22, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Jul 18, 2024

Prepare user SDK for the user resource/datasource rework (continuation of #2936):

  • add missing user parameters
  • fix typos
  • add missing integration tests (default creation, creation with all properties and parameters, altering, rename, tags)
  • change a few types (mostly identifiers to the DefaultX values)
  • document not working parts
  • add snowflake objects assertions (manually)

What's not a part of this PR:

  • new type of assertions could be added (assertion for parameters list)
  • additions in 8.26 version of Snowflake (the docs were added today, so it will be a separate change)
  • setting/unsetting different policies

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review July 18, 2024 12:35
Copy link

Integration tests failure for bd39522ef256ccf2173a72f38d5d4283c08e6fad

Copy link

Integration tests failure for 30c48223ee7ca00e6b56277f5d1ffc01f203249f

@mogren
Copy link

mogren commented Jul 19, 2024

Any chance that TYPE can be a parameter here?

https://docs.snowflake.com/en/sql-reference/sql/create-user#label-user-type-property-person

The issue we have is that I can't create SERVICE users, which is a great security feature.

Copy link

Integration tests failure for 52ce9768a75cd9f0dbdc3c23c591633a2edd9308

Copy link

Integration tests failure for 1d3eebc86688ee3074f32d047fc7b4e2107aacb0

Copy link

Integration tests failure for 1d3eebc86688ee3074f32d047fc7b4e2107aacb0

# Conflicts:
#	v1-preparations/ESSENTIAL_GA_OBJECTS.MD
Copy link

Integration tests cancelled for d34f3a57731fc6a1f7904c39097b57df10bf562c

@sfc-gh-asawicki sfc-gh-asawicki merged commit 1127bb3 into main Jul 22, 2024
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the adjust-user-sdk branch July 22, 2024 13:46
sfc-gh-jcieslak pushed a commit that referenced this pull request Jul 26, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.94.0](v0.93.0...v0.94.0)
(2024-07-26)


### 🎉 **What's new:**

* Add missing session parameters
([#2936](#2936))
([4ce662d](4ce662d))
* Adjust user SDK
([#2947](#2947))
([1127bb3](1127bb3))
* Better tests poc
([#2917](#2917))
([ef496c2](ef496c2))
* Introduce assertions generators part1
([#2952](#2952))
([1582a9f](1582a9f))
* Introduce assertions generators part2
([#2956](#2956))
([f715e8a](f715e8a))
* network policy v1 readiness
([#2914](#2914))
([3408c3f](3408c3f))
* Rework schema datasource
([#2954](#2954))
([f70e40e](f70e40e))
* Rework schema resource
([#2955](#2955))
([400a5c8](400a5c8))
* Role v1 readiness
([#2916](#2916))
([32c7690](32c7690))
* Schema SDK upgrade
([#2945](#2945))
([bca0836](bca0836))
* Streamlit v1 readiness
([#2930](#2930))
([aa42260](aa42260))


### 🔧 **Misc**

* Remove deprecation from unsafe execute
([#2941](#2941))
([ed712d7](ed712d7))
* Update documentation
([#2931](#2931))
([da98bc3](da98bc3))


### 🐛 **Bug fixes:**

* ATTRIBUTE set(string) parsing for cortex search service
([#2953](#2953))
([70a1c9a](70a1c9a))
* external function header parsing and add missing privileges
([#2961](#2961))
([9d882fe](9d882fe))
* Fix sync_password field for Azure scim clients
([#2950](#2950))
([6781133](6781133))
* Fix tests and relax warehouse validations
([#2959](#2959))
([dd01ce9](dd01ce9)),
closes
[#2948](#2948)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants