feat: SAML2 integration v1 readiness #2868

sfc-gh-jmichalak · 2024-06-13T09:05:52Z

Introduce snowflake_saml2_resource (to be consistent with docs and sql) and deprecate snowflake_saml_resource
Fix migration guide
Fix checking errors for invalid terraform configurations
Added one more test for scim migrator
Altered SDK:
- improved enums
- marked some fields as optional
- introduced enums for some fields (they were not here before because of confusing docs, added to docs improvements list)
- added new issues to objects lists

Test Plan

acceptance tests

…

References

https://docs.snowflake.com/en/sql-reference/sql/create-security-integration-saml2

github-actions · 2024-06-13T09:59:23Z

Integration tests success for afe7fc6bb43da7e66fd33ec533b1b284141d3f43

github-actions · 2024-06-13T10:16:38Z

Integration tests failure for 1318b9348d62824fab4ee77738dd27496852de76

examples/resources/snowflake_saml2_integration/import.sh

examples/resources/snowflake_saml2_integration/resource.tf

pkg/resources/scim_integration_acceptance_test.go

pkg/resources/custom_diffs.go

pkg/resources/saml2_integration.go

sfc-gh-asawicki

Gave a few comments but I am worried because the schema and handling in create/update are inconsistent with database/warehouse (and I think that some of the use cases won't work correctly with the current setup). Let's talk.

examples/resources/snowflake_saml2_integration/resource.tf

pkg/acceptance/helpers/common.go

pkg/resources/custom_diffs.go

pkg/resources/scim_integration_acceptance_test.go

pkg/sdk/security_integrations_def.go

pkg/resources/testdata/TestAcc_Saml2Integration/complete/test.tf

pkg/resources/saml2_integration_acceptance_test.go

pkg/resources/saml2_integration.go

github-actions · 2024-06-18T10:34:23Z

Integration tests failure for 5fe1bccd5eed3b48af6951416ff93817819a2294

gitguardian · 2024-06-27T08:13:20Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

github-actions · 2024-06-27T08:34:24Z

Integration tests failure for 2b9bc6f3513fabae366bb89af58efad0b8eba461

github-actions · 2024-06-27T08:35:36Z

Integration tests failure for 9a4acde0ba38637b33fcbbfd6266f4e703c02a42

…k-si-v1

# Conflicts: # pkg/resources/custom_diffs.go # pkg/resources/scim_integration_state_upgraders.go

github-actions · 2024-07-01T13:14:41Z

Integration tests failure for f49e7aca00ea52577f124a82a65a88b25ad30c3c

github-actions · 2024-07-01T13:35:50Z

Integration tests failure for b9209c612a86c3b2f6cffab9ee5d95ecd3b175c7

github-actions · 2024-07-02T08:09:49Z

Integration tests failure for 2620ea6b7523f8b7953601852b9ca346ba7f9f05

github-actions · 2024-07-02T08:29:43Z

Integration tests failure for d93db50437a2b4407abb80ffa2666ee95f286e88

github-actions · 2024-07-02T08:32:45Z

Integration tests failure for c904c2272423b9bd6121356e92ef9a42b0c3eff5

pkg/resources/saml2_integration.go

pkg/schemas/saml_security_integration.go

pkg/resources/common.go

pkg/schemas/saml_security_integration.go

pkg/resources/helpers.go

pkg/resources/saml2_integration.go

sfc-gh-asawicki · 2024-07-02T12:03:34Z

pkg/resources/saml2_integration.go

+		// These are all identity sets, needed for the case where:
+		// - previous config was empty (therefore Snowflake defaults had been used)
+		// - new config have the same values that are already in SF
+		if !d.GetRawConfig().IsNull() {


this can be also made a bit nicer after #2900

Addressed in #2912

pkg/resources/saml2_integration.go

github-actions · 2024-07-02T12:20:51Z

Integration tests failure for 7b33e11b7a65b2cf3c8f78c11ca566444365eda2

# Conflicts: # pkg/resources/helpers.go # pkg/resources/scim_integration.go # pkg/resources/scim_integration_acceptance_test.go # v1-preparations/CHANGES_BEFORE_V1.md

sfc-gh-jmichalak

lgtm

github-actions · 2024-07-03T10:18:18Z

Integration tests failure for 3b908672b7bb1bb0c424a375f7d89c700e98c14d

sfc-gh-asawicki · 2024-07-04T09:54:02Z

pkg/resources/custom_diffs_test.go

@@ -301,8 +301,8 @@ func TestForceNewIfChangeToEmptySet(t *testing.T) {
 		}, {
 			name: "non-empty to empty",
 			stateValue: map[string]string{
-				"value.#": "1",
-				"value.0": "foo",
+				"value.#":          "1",


please add some comment to explain this funny stuff (in the next PR)

Addressed in #2912

# Conflicts: # v1-preparations/ESSENTIAL_GA_OBJECTS.MD

github-actions · 2024-07-04T14:33:39Z

Integration tests failure for 0c96ab1ca28c01fd5a42ed06b80bb4290bca6d19

Changes: - New oauth integration for partner applications added - Examples added - Migration Guide was added in the previous pr (oauth for custom clients) - Common description for not detecting external changes and using manual re-creation added - Left TODOs for UNSETs not working - Address things from #2868 ## Test Plan  * [x] acceptance tests  ## References  * [CREATE](https://docs.snowflake.com/en/sql-reference/sql/create-security-integration-oauth-snowflake)

🤖 I have created a release *beep* *boop* --- ## [0.93.0](v0.92.0...v0.93.0) (2024-07-10) ### 🎉 **What's new:** * Add OAUTH integration for custom clients ([#2908](#2908)) ([d9b557f](d9b557f)) * Add oauth integration for partner applications ([#2912](#2912)) ([91788e5](91788e5)) * Add support for cortex search service ([#2860](#2860)) ([43aa89f](43aa89f)) * API Authentication integration v1 readiness ([#2898](#2898)) ([91931da](91931da)) * External Oauth integration v1 readiness ([#2907](#2907)) ([ed237c3](ed237c3)) * Generate show outputs with mappers ([#2886](#2886)) ([1cada88](1cada88)) * Introduce security integrations datasource ([#2892](#2892)) ([7f6c657](7f6c657)) * SAML2 integration v1 readiness ([#2868](#2868)) ([d0c136d](d0c136d)) * SCIM integration v1 readiness ([#2846](#2846)) ([269df6b](269df6b)) * Security integrations datasource v1 readiness ([#2913](#2913)) ([d10474a](d10474a)) * standard database v1 readiness ([#2842](#2842)) ([3c11953](3c11953)) * Warehouse redesign final touches ([#2900](#2900)) ([0eab636](0eab636)) * Warehouse redesign part1 ([#2864](#2864)) ([6664457](6664457)) * Warehouse redesign part2 ([#2887](#2887)) ([1aaf417](1aaf417)) * Warehouse redesign part3 ([#2890](#2890)) ([873a1ed](873a1ed)) * Warehouse redesign part4 ([#2893](#2893)) ([d525fd9](d525fd9)) ### 🔧 **Misc** * Add documentation on unset and defaults ([#2882](#2882)) ([85a7836](85a7836)) * apply minor database changes ([#2872](#2872)) ([6ccac59](6ccac59)) * Apply new resource conventions to scim integration ([#2891](#2891)) ([e11e608](e11e608)) * Improve generator template organization ([#2820](#2820)) ([5035e2f](5035e2f)) * Nuke stale objects ([#2869](#2869)) ([9c4a117](9c4a117)) * Show a possible solution for [#2877](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2877) ([#2878](#2878)) ([6fb437b](6fb437b)) * Validations cleanup and old grants removal ([#2884](#2884)) ([05b7eee](05b7eee)) ### 🐛 **Bug fixes:** * Add disclaimers and fix tests ([#2905](#2905)) ([1deaedc](1deaedc)) * Fix cortex search service ([#2904](#2904)) ([763d06c](763d06c)) * use suppressQuoting to fix stage file_format permadiff ([#2885](#2885)) ([fd70f6e](fd70f6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

Add Saml2 resource

2099582

sfc-gh-jmichalak requested review from sfc-gh-jcieslak and sfc-gh-asawicki June 13, 2024 09:05

sfc-gh-jmichalak added 2 commits June 13, 2024 11:07

Merge remote-tracking branch 'origin/main' into jmichalak-si-v1

afe7fc6

Fix docs

1318b93

sfc-gh-jcieslak reviewed Jun 17, 2024

View reviewed changes

sfc-gh-asawicki requested changes Jun 17, 2024

View reviewed changes

sfc-gh-jcieslak reviewed Jun 17, 2024

View reviewed changes

pkg/resources/saml2_integration.go Outdated Show resolved Hide resolved

sfc-gh-jmichalak added 3 commits June 17, 2024 13:52

Merge remote-tracking branch 'origin/main' into jmichalak-si-v1

f35a9be

Review fixes

a426f79

Fix

5fe1bcc

sfc-gh-jmichalak added 3 commits June 24, 2024 13:50

Merge remote-tracking branch 'origin/main' into jmichalak-si-v1

d8d3b39

Check rsa key hash

2b9bc6f

Add show_output and describe_output

9a4acde

sfc-gh-jcieslak added 4 commits June 28, 2024 08:52

Merge remote-tracking branch 'refs/remotes/origin/main' into jmichala…

801cb23

…k-si-v1

Merge branch 'refs/heads/main' into jmichalak-si-v1

c09fbe4

# Conflicts: # pkg/resources/custom_diffs.go # pkg/resources/scim_integration_state_upgraders.go

Apply resource conventions

cd68058

Merge branch 'refs/heads/main' into jmichalak-si-v1

b9209c6

sfc-gh-jcieslak force-pushed the jmichalak-si-v1 branch from f49e7ac to b9209c6 Compare July 1, 2024 13:12

sfc-gh-jcieslak force-pushed the jmichalak-si-v1 branch from 2620ea6 to d93db50 Compare July 2, 2024 08:04

Apply resource conventions

c904c22

sfc-gh-jcieslak force-pushed the jmichalak-si-v1 branch from d93db50 to c904c22 Compare July 2, 2024 08:05

sfc-gh-asawicki self-requested a review July 2, 2024 10:52

sfc-gh-jmichalak commented Jul 2, 2024

View reviewed changes

pkg/resources/saml2_integration.go Outdated Show resolved Hide resolved

pkg/resources/saml2_integration.go Show resolved Hide resolved

pkg/resources/saml2_integration.go Outdated Show resolved Hide resolved

pkg/schemas/saml_security_integration.go Outdated Show resolved Hide resolved

Test fix

7b33e11

sfc-gh-asawicki requested changes Jul 2, 2024

View reviewed changes

sfc-gh-jcieslak added 2 commits July 3, 2024 10:40

Changes after review

53dc57e

Changes after review

8e87551

sfc-gh-jcieslak force-pushed the jmichalak-si-v1 branch from d03340e to 8e87551 Compare July 3, 2024 09:11

sfc-gh-jcieslak added 2 commits July 3, 2024 11:12

Merge branch 'refs/heads/main' into jmichalak-si-v1

2e3ee43

# Conflicts: # pkg/resources/helpers.go # pkg/resources/scim_integration.go # pkg/resources/scim_integration_acceptance_test.go # v1-preparations/CHANGES_BEFORE_V1.md

Changes after merge

3b90867

sfc-gh-jmichalak commented Jul 3, 2024

View reviewed changes

sfc-gh-asawicki self-requested a review July 4, 2024 09:42

sfc-gh-asawicki previously approved these changes Jul 4, 2024

View reviewed changes

Merge branch 'refs/heads/main' into jmichalak-si-v1

0c96ab1

# Conflicts: # v1-preparations/ESSENTIAL_GA_OBJECTS.MD

sfc-gh-jcieslak dismissed sfc-gh-asawicki’s stale review via 0c96ab1 July 4, 2024 13:31

sfc-gh-asawicki approved these changes Jul 4, 2024

View reviewed changes

sfc-gh-jcieslak merged commit d0c136d into main Jul 4, 2024
8 of 9 checks passed

sfc-gh-jcieslak deleted the jmichalak-si-v1 branch July 4, 2024 13:38

snowflake-release-please bot mentioned this pull request Jul 4, 2024

chore(main): release 0.93.0 #2866

Merged

sfc-gh-jcieslak mentioned this pull request Jul 5, 2024

feat: Add oauth integration for partner applications #2912

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: SAML2 integration v1 readiness #2868

feat: SAML2 integration v1 readiness #2868

sfc-gh-jmichalak commented Jun 13, 2024 •

edited

Loading

github-actions bot commented Jun 13, 2024

github-actions bot commented Jun 13, 2024

sfc-gh-asawicki left a comment

github-actions bot commented Jun 18, 2024

gitguardian bot commented Jun 27, 2024 •

edited

Loading

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jul 1, 2024

github-actions bot commented Jul 1, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

sfc-gh-asawicki Jul 2, 2024

sfc-gh-jcieslak Jul 5, 2024

github-actions bot commented Jul 2, 2024

sfc-gh-jmichalak left a comment

github-actions bot commented Jul 3, 2024

sfc-gh-asawicki Jul 4, 2024

sfc-gh-jcieslak Jul 5, 2024

github-actions bot commented Jul 4, 2024

feat: SAML2 integration v1 readiness #2868

feat: SAML2 integration v1 readiness #2868

Conversation

sfc-gh-jmichalak commented Jun 13, 2024 • edited Loading

Test Plan

References

github-actions bot commented Jun 13, 2024

github-actions bot commented Jun 13, 2024

sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 18, 2024

gitguardian bot commented Jun 27, 2024 • edited Loading

️✅ There are no secrets present in this pull request anymore.

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jul 1, 2024

github-actions bot commented Jul 1, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

sfc-gh-asawicki Jul 2, 2024

Choose a reason for hiding this comment

sfc-gh-jcieslak Jul 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2024

sfc-gh-jmichalak left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 3, 2024

sfc-gh-asawicki Jul 4, 2024

Choose a reason for hiding this comment

sfc-gh-jcieslak Jul 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 4, 2024

sfc-gh-jmichalak commented Jun 13, 2024 •

edited

Loading

gitguardian bot commented Jun 27, 2024 •

edited

Loading