chore: Replace parsing function for saving granted object names #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jcieslak
force-pushed
the
better-show-grants-identifier-parsing
branch
from
71a09fd
to
b5a1a69
Compare
|
Integration tests failure for 71a09fd6163e97f561cc69ae6172329e76568a8d |
|
Integration tests failure for b5a1a69a533b5c62773b49fcb60773d9bb5a27ab |
sfc-gh-jcieslak
force-pushed
the
better-show-grants-identifier-parsing
branch
from
fc1dc0b
to
2d5e8d9
Compare
|
Integration tests failure for 4a8b235ca07bf0f38556dff2d363b96602fb35ca |
|
Integration tests failure for 8c947f1d294cc30f8d1e4d73062ffde50c4be53e |
|
Integration tests failure for fc1dc0bd48a257c21cd73379215a26b2cfc8accf |
|
Integration tests failure for 2d5e8d999d4b610a197ba0f8764a897528513a79 |
sfc-gh-jmichalak
previously approved these changes
May 16, 2024
| @@ -511,7 +515,7 @@ func TestAcc_GrantOwnership_OnFuture_InSchema_ToAccountRole(t *testing.T) { | |||
| In: &sdk.ShowGrantsIn{ | |||
| Schema: sdk.Pointer(sdk.NewDatabaseObjectIdentifier(databaseName, schemaName)), | |||
| }, | |||
| }, sdk.ObjectTypeTable, accountRoleName, fmt.Sprintf("%s.%s.<TABLE>", databaseName, schemaName)), | |||
| }, sdk.ObjectTypeTable, accountRoleName, fmt.Sprintf("\"%s\".\"%s\".\"<TABLE>\"", databaseName, schemaName)), | |||
There was a problem hiding this comment.
Nit: use ` for readability
sfc-gh-asawicki
requested changes
May 16, 2024
sfc-gh-asawicki
previously approved these changes
May 16, 2024
|
Integration tests cancelled for ed4b2a8d7830a122fc3b65381d3d5016d36ebee7 |
|
Integration tests cancelled for 31c635fa2ce64e6bdddc32edc6c5b213666e323f |
sfc-gh-jmichalak
approved these changes
May 16, 2024
sfc-gh-jmichalak
pushed a commit
that referenced
this pull request
May 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.91.0](v0.90.0...v0.91.0) (2024-05-16) ### 🎉 **What's new:** * add snowflake_grant_application_role resource ([#2690](#2690)) ([838d241](838d241)) * datasource database role ([#2731](#2731)) ([319ddc3](319ddc3)) ### 🔧 **Misc** * Add few documentation adjustments ([#2789](#2789)) ([6db8bf3](6db8bf3)) * Bump dependencies ([#2802](#2802)) ([54ea6bc](54ea6bc)) * Replace parsing function for saving granted object names ([#2813](#2813)) ([175cfc7](175cfc7)) ### 🐛 **Bug fixes:** * Fix sweepers ([#2800](#2800)) ([a01115e](a01115e)) * Invoke SetId immediately after alert creation ([#2786](#2786)) ([181b4d0](181b4d0)) * Update the tests after snowflake bugfix ([#2806](#2806)) ([6843c1a](6843c1a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add better parsing of identifiers returned by SHOW GRANTS. It should resolve some of our issues with failing tests (they sometimes fail because they depend on the generated name of a resource and whether they will be quoted in the output provided by Snowflake).
New
ParseObjectIdentifierfunction is based onDecodeSnowflakeParameterIDfunction used in resources. As a fallback (becauseParseObjectIdentifiercan fail)NewObjectIdentifierFromFullyQualifiedNamewill be used.