Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfaults in Enumerator #13

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Fix segfaults in Enumerator #13

merged 1 commit into from
Mar 11, 2020

Conversation

a1ien
Copy link
Contributor

@a1ien a1ien commented Mar 10, 2020

Fixes: #9

@a1ien
Copy link
Contributor Author

a1ien commented Mar 10, 2020

Test fail same reason as #11
We must update libudev to 240 or grater.
Or we can use this hack in Enumerator::new

let ptr = try_alloc!(unsafe { ffi::udev_enumerate_new([].as_mut_ptr() as *mut ffi::udev) });

@Drakulix
Copy link
Member

Could you rebase against #14 / current master to verify, that the tests now work as expected?

@a1ien a1ien force-pushed the devices_enumeration branch from b6e5748 to d4014c6 Compare March 11, 2020 11:32
@a1ien
Copy link
Contributor Author

a1ien commented Mar 11, 2020

Done

@Drakulix Drakulix merged commit f4620f2 into Smithay:master Mar 11, 2020
@a1ien a1ien deleted the devices_enumeration branch March 11, 2020 11:42
@anelson anelson mentioned this pull request Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsafe: Devices does not keep Enumerator referenced
2 participants
@a1ien @Drakulix