Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix browser-xhr bundling for es5 lib #2

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

pelle
Copy link
Contributor

@pelle pelle commented Feb 13, 2017

When adding ipfs-mini to a web pack like build process for a browser it can't find the xml http request object.

It's a pretty simple fix that just needs a mapping from the lib version to the browser lib version.

ipfs-mini

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Internal code generators and templates are updated (if necessary)
  • Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2c2522f on pelle:fix-es5-xhr into 9f3c2e1 on SilentCicero:master.

@SilentCicero SilentCicero merged commit c30f7c6 into SilentCicero:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants