Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browse_website headless mode for Firefox #2816

Merged
merged 9 commits into from
Apr 27, 2023
Merged

Fix browse_website headless mode for Firefox #2816

merged 9 commits into from
Apr 27, 2023

Conversation

Irmius
Copy link
Contributor

@Irmius Irmius commented Apr 21, 2023 •
edited
Loading

make changes to work docker with mac m1 chip browse_website command as chromium drivers is crashing and need to use firefox. Update README.md

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@Irmius
fix docker-compose.yml to attach proper workspace
e275fd1 
make changes to work docker with mac m1 chip browse_website command as chromium drivers is crashing and need to use firefox.
Update README.md
@Irmius Irmius changed the title fix docker-compose.yml to attach proper workspace fix mac m1 docker selenium(browse_website command) issue Apr 21, 2023
Wladastic
Wladastic reviewed Apr 21, 2023
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 21, 2023
k-boikov
k-boikov reviewed Apr 21, 2023
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@k-boikov k-boikov added needs restructuring PRs that should be split or restructured platform dependent When something works but not on all platforms labels Apr 21, 2023
@ntindle ntindle added the docker label Apr 22, 2023
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 24, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@Irmius Irmius requested review from Wladastic and k-boikov April 24, 2023 16:06
@vercel
Copy link

vercel bot commented Apr 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview 💬 1 unresolved Apr 27, 2023 5:29pm

@github-actions github-actions bot added size/s and removed size/xs labels Apr 27, 2023
@vercel vercel bot temporarily deployed to Preview April 27, 2023 07:45 Inactive
@Pwuts Pwuts added this to the v0.3.0 release milestone Apr 27, 2023
@vercel vercel bot temporarily deployed to Preview April 27, 2023 14:51 Inactive
@Pwuts Pwuts added function: browse and removed platform dependent When something works but not on all platforms labels Apr 27, 2023
@Pwuts Pwuts changed the title fix mac m1 docker selenium(browse_website command) issue Fix browse_website headless mode for Firefox Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.06 ⚠️

Comparison is base (3d89ed1) 54.89% compared to head (55dd57d) 54.83%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2816      +/-   ##
==========================================
- Coverage   54.89%   54.83%   -0.06%     
==========================================
  Files          65       65              
  Lines        3015     3018       +3     
  Branches      507      508       +1     
==========================================
  Hits         1655     1655              
- Misses       1224     1227       +3     
  Partials      136      136
Impacted Files Coverage Δ
autogpt/commands/web_selenium.py 86.84% <25.00%> (-3.57%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts self-assigned this Apr 27, 2023
@vercel vercel bot temporarily deployed to Preview April 27, 2023 17:12 Inactive
Pwuts
Pwuts approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually by gNoLEm on Discord, thanks! <3

@Pwuts Pwuts merged commit 6b4ad1f into Significant-Gravitas:master Apr 27, 2023
@Pwuts Pwuts mentioned this pull request Jun 15, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pwuts Pwuts Pwuts approved these changes

@Wladastic Wladastic Awaiting requested review from Wladastic

@k-boikov k-boikov Awaiting requested review from k-boikov

Assignees

@Pwuts Pwuts

Labels
docker function: browse needs restructuring PRs that should be split or restructured size/s
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Irmius @Wladastic @Pwuts @k-boikov @ntindle