Carbon black mapping wrong and fix wild card #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will close #814 |
|
@tungn12: I wouldn't claim I'm 100% sure about CB syntax myself, but are you sure about the AND operators in your after-example? At least testing with a process "foo.exe" launched with "bar" as cmdline and "baz.exe" as parent name, this query would match for me: Wouldn't this suggest that the parts after the AND in your query is checked against more than just the cmdline? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remap Image to path since some case process_name doesn't work.
Fix leading wildcard and some escaped characters:
rules/windows/process_creation/win_netsh_wifi_credential_harvesting.yml
Before: (cmdline:netsh\ wlan\ s\ p*\ k*=clear)*
After: "(cmdline:"netsh wlan s" and p and k and =clear)"