Fix some infinite loops #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vividviolet
reviewed
Nov 1, 2022
There was a problem hiding this comment.
Ooh this is awesome! Is it possible to fix this in encode/decode layer as well? Maybe I'm testing this wrong but I still get an infinite loop if I try passing in something like this:
const props = { onPress, title: "This is a button", onPress: () => console.log("click") };
const button = root.createComponent('Button', {...props, self: props});
|
@vividviolet thanks for the note about encoding — I had that in a locally-applied change but I didn't bring it into this branch, will get it done. Decoding should not have any need for this, since the self-referencing structures will be stripped out during encoding. |
lemonmade
force-pushed
the
fix-some-infinite-loops
branch
from
66e8786 to
b593447
Compare
This comment has been minimized.
This comment has been minimized.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents a few infinite loops that could happen in
@remote-uipackages related to iterating over potentially self-referencing structures. This came up in a few different places:@remote-ui/core, we try to "hot swap" function properties so that updates to functions need to be sent over the RPC bridge less often. This "hot swapping" is done recursively for props that are objects or arrays.@remote-ui/rpc, we provide aretainandreleasemethod that will iterate through deeply nested objects to retain all nested functions.