Remove internal state from AnchorImage explainer #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 30, 2021 11:33
added 2 commits
August 2, 2021 15:29
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 86.92% 86.87% -0.05%
==========================================
Files 58 58
Lines 8328 8350 +22
==========================================
+ Hits 7239 7254 +15
- Misses 1089 1096 +7
|
jklaise
suggested changes
Aug 3, 2021
There was a problem hiding this comment.
Thanks @adriangonz, looking good!
The only two things I would suggest are:
- Keep to one module for the public class + utility functions + sampler as the implementation is not that complex to warrant splitting out into several modules, same for keeping to one test module
- We should check what the increase in test times is due to the extra test that calls
explainas it's expensive (looks like adding ~3 minutes on top compared to master). Maybe we should combine the stateless test together with the main test to reduce runtimes (at the expense of tests not testing a single behaviour) ?
jklaise
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #453 (only covering one explainer)
Changelog
AnchorImageSamplerobject_scalestatic method into a utils moduleAnchorImageexplainer holds no internal state