Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings reference in runtime docs #1109

Merged
merged 13 commits into from
Apr 20, 2023
Merged

Fix settings reference in runtime docs #1109

merged 13 commits into from
Apr 20, 2023

Conversation

adriangonz
Copy link
Contributor

No description provided.

@adriangonz adriangonz requested a review from ascillitoe April 19, 2023 16:35
@ascillitoe ascillitoe mentioned this pull request Apr 20, 2023
Merged
2 tasks
ascillitoe
ascillitoe reviewed Apr 20, 2023
View reviewed changes
docs/requirements.txt Outdated Show resolved Hide resolved
ascillitoe
ascillitoe approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@ascillitoe ascillitoe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Edit: just noticed the new RTD install logic does introduce a few errors with protobuf in the RTD build logs (during installation), which in turn leads to errors with optimum.onnxruntime. However, I can't imagine this affecting the docs buidl itself...

@adriangonz
Copy link
Contributor Author

Docs seem to now be working for both the Huggingface and Alibi Detect runtimes!

@adriangonz adriangonz merged commit 1c9ca37 into SeldonIO:master Apr 20, 2023
@adriangonz adriangonz deleted the fix-runtime-docs-reference branch April 20, 2023 15:54
adriangonz pushed a commit that referenced this pull request Apr 20, 2023
Fix settings reference in runtime docs (#1109)
3f399d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascillitoe ascillitoe ascillitoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriangonz @ascillitoe