Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoginRequest needs to verify 0 termination of login and password arrays #227

Closed
nemerle opened this issue Jan 3, 2018 · 1 comment
Closed

LoginRequest needs to verify 0 termination of login and password arrays #227

nemerle opened this issue Jan 3, 2018 · 1 comment
Labels
good first issue Great issue for newcomers looking for ways to contribute

Comments

@nemerle
Copy link
Contributor

nemerle commented Jan 3, 2018

Expected behavior

Both of those member variables should be 0 terminated after receiving data, to prevent any trouble when processing login/password by the rest of the system.
@nemerle nemerle added the good first issue Great issue for newcomers looking for ways to contribute label Jan 3, 2018
eos428 pushed a commit to eos428/Segs that referenced this issue Apr 18, 2018
Fixing Issue Segs#227 (Zero-Termination of Login and Password Arrays)
ca5021e 
Affected files:
AuthHandler.cpp and AuthHandler.h
@broxen broxen mentioned this issue Apr 18, 2018
Merged
nemerle added a commit that referenced this issue Apr 18, 2018
@nemerle
Merge pull request #344 from eos428/master
6e4bfb3 
Fixing Issue #227 (Zero-Termination of Login and Password Arrays)
nemerle added a commit to nemerle/Segs that referenced this issue Apr 18, 2018
@nemerle
Merge pull request Segs#344 from eos428/master Fixing Issue Segs#227 …
7bf1fdd 
…(Zero-Termination of Login and Password Arrays)
@broxen
Copy link
Collaborator

broxen commented Apr 22, 2018

This is closed as of #344

@broxen broxen closed this as completed Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Great issue for newcomers looking for ways to contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nemerle @broxen