Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapInstance::on_description_and_battlecry is unhandled #191

Closed
erpmario opened this issue Dec 23, 2017 · 2 comments
Closed

MapInstance::on_description_and_battlecry is unhandled #191

erpmario opened this issue Dec 23, 2017 · 2 comments
Assignees
@broxen

Comments

@erpmario
Copy link
Member

Summary

This is one of many events in MapInstance.cpp that is unhandled in one way or another.

Details

Begins on line 686 of MapInstance.cpp.
When called, it gives "Unhandled description and battlecry request" along with description and battlecry to qWarning().
TODO: client expects us to force it to fill description and battlecry fields in UI?
@broxen
Copy link
Collaborator

broxen commented Mar 12, 2018

Current build saves information entered on the ID (profile) page correctly, but does not load BattleCry or Description on this page properly. Not sure if there's another MapEvent that is supposed to send this information, or if we're sending something incorrect elsewhere, but this is sort of "half" working.

@broxen broxen mentioned this issue Mar 22, 2018
Merged
@broxen broxen self-assigned this Apr 5, 2018
@broxen
Copy link
Collaborator

broxen commented Apr 10, 2018

To the best of my knowledge, this now does everything it's supposed to do. Closing.

@broxen broxen closed this as completed Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@broxen broxen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@broxen @erpmario