Added a configuration to define the reports retention period #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Release 1.0][Fix] Fixed some coding standards
modules/retainnumberofreports.py
Outdated
Comment on lines
11
to
13
| from modules import gcpaudit | ||
| from modules import awsaudit | ||
| from modules import azureaudit |
There was a problem hiding this comment.
By importing the modules by default, will result in breaking of the tool
Let's assume the case, where a user is running audit for Azure environment
from modules import awsaudit
The awsaudit file will run this line
https://github.com/opstree/cs-suite/blob/master/modules/awsaudit.py#L30
Which basically requires AWS cli to be configured.
Hence breaking it, as the user will be running the scan only for Azure.
Can we import these based on the environment parameter given by the user
Something like this
https://github.com/opstree/cs-suite/blob/master/cs.py#L65
There was a problem hiding this comment.
Done with the suggested changes, please review
importing module while it call
shivankar-madaan
added a commit
that referenced
this pull request
Oct 16, 2019
|
Thanks guys!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CS-Suite runs in a mode where either it saves all the reports or none. We would like to add a configuration where we can define reports retention period
Added a parameter -n or --number using which end user can define how many reports to be retained.