Update addon.tab API Docs #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samq64
commented
Oct 16, 2024
Samq64
commented
Oct 16, 2024
| **In most cases, you should use the [`userscripts` property of the addon manifest](/docs/reference/addon-manifest/#userscripts-and-userstyles) instead.** | ||
|
|
||
| {{< admonition warning >}} | ||
| In most cases, you should use the [`userscripts` property of the addon manifest](/docs/reference/addon-manifest/#userscripts-and-userstyles) instead. |
There was a problem hiding this comment.
Should we officially deprecate this and also mention not importing 3rd-party libraries with it?
There was a problem hiding this comment.
I'm not sure, but we could write down that usually we prefer addons that don't import any libraries.
There was a problem hiding this comment.
Suggested change
| In most cases, you should use the [`userscripts` property of the addon manifest](/docs/reference/addon-manifest/#userscripts-and-userstyles) instead. | |
| Use the standard browser import instead. |
There was a problem hiding this comment.
I'm not sure, but we could write down that usually we prefer addons that don't import any libraries.
I think that fits better in the best practices page and I want to try to keep this PR to just the API.
Hans5958
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #472
Related PRs: