Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): let pathes in 'env_add_path' be added ascendantly #3788

Merged
merged 3 commits into from
May 11, 2020

Conversation

niheaven
Copy link
Member

Fix #3785

lib/install.ps1 Outdated Show resolved Hide resolved
Co-Authored-By: Chawye Hsu <chawyehsu@hotmail.com>
lib/install.ps1 Outdated Show resolved Hide resolved
@Ash258
Copy link
Contributor

Ash258 commented Dec 16, 2019

Is there any possibility of breaking current behaviour? I cannot think about anything right now.

@niheaven
Copy link
Member Author

Just order in %PATH%, which shouldn't break anything. Maintainer typically write env_add_path ascendantly, I thought.

@chawyehsu
Copy link
Member

ping @r15ch13

@r15ch13 r15ch13 changed the title fix(install): let pathes in 'env_add_path' be added ascendantly fix(install): let pathes in 'env_add_path' be added ascendantly May 11, 2020
@r15ch13 r15ch13 merged commit f91968c into ScoopInstaller:develop May 11, 2020
@niheaven niheaven deleted the fix-env_add_path branch May 12, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants