Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should maxiters and epochs be disambiguated? #842

Closed
avik-pal opened this issue Oct 7, 2024 · 0 comments
Closed

Should maxiters and epochs be disambiguated? #842

avik-pal opened this issue Oct 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@avik-pal
Copy link
Member

avik-pal commented Oct 7, 2024

Currently, these are being used interchangeably in OptimizationOptimisers to mean epochs. The general meaning atleast how they are used in DL code-bases:

  • maxiters -- the total number of batched observations used for training
  • epochs -- number of times we have iterated over the entire dataset.

We should make a similar distinction I feel. Ofcourse, throwing an error if both are specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants