Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite fnm in Rust (merge fnm.rs into fnm) — adding Windows support! #246

Merged
merged 8 commits into from
Oct 7, 2020
Merged

Rewrite fnm in Rust (merge fnm.rs into fnm) — adding Windows support! #246

merged 8 commits into from
Oct 7, 2020

Conversation

Schniz
Copy link
Owner

@Schniz Schniz commented Oct 4, 2020 •
edited
Loading

As I already mentioned on Twitter, this PR will migrate fnm to a Rust implementation.

It started as an experiment but I'm using it for a while now and I think it's the right decision for fnm.

This is a big change. It's going to take some time to stabilize.
I'll comment here the big differences and what we're gaining from this move.

New Features

  • 🔥 Windows support 🔥
    • Both PowerShell and WinCmd are supported, however only PowerShell have the same test coverage as Zsh/Bash/Fish
    • All features should work, including --use-on-cd

Breaking Changes

  • --multi is now the default. I need to add a warning that this field is deprecated. Maybe to replace it with --single if we want to allow a single version.
  • LTS aliases scheme has changed (latest-dubnium => lts-dubnium)

Internal Changes

  • Stopped using DOM parsing for finding links, instead using index.json
  • Feature tests are written in a higher-level "lisp"-y style, which generates test files for all the given shells.

@Schniz Schniz self-assigned this Oct 4, 2020
@vercel
Copy link

vercel bot commented Oct 4, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/schniz/fnm/eosruyy13
✅ Preview: https://fnm-git-merge-fnm-rust.schniz.vercel.app

@Schniz Schniz marked this pull request as draft October 4, 2020 12:25
@Schniz Schniz added the PR: Internal An internal work has been made label Oct 5, 2020
@Schniz Schniz marked this pull request as ready for review October 7, 2020 06:06
@Schniz Schniz changed the title Merge fnm.rs with fnm Rewrite fnm in Rust (merge fnm.rs into fnm) Oct 7, 2020
@Schniz Schniz changed the title Rewrite fnm in Rust (merge fnm.rs into fnm) Rewrite fnm in Rust (merge fnm.rs into fnm) — adding Windows support! Oct 7, 2020
@Schniz Schniz merged commit 9ba282a into master Oct 7, 2020
@Schniz Schniz deleted the merge-fnm-rust branch October 7, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Schniz Schniz

Labels
PR: Internal An internal work has been made
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Schniz